Date: Sat, 24 Nov 2001 12:18:42 +0300 From: "Andrey Simonenko" <simon@comsys.ntu-kpi.kiev.ua> To: "Andrew R. Reiter" <arr@FreeBSD.ORG> Cc: <freebsd-audit@FreeBSD.ORG> Subject: Re: xtend - unsafe signal handlers patch Message-ID: <002101c174c9$02805d60$6d36120a@comsys.ntukpi.kiev.ua> References: <Pine.NEB.3.96L.1011124014918.51286B-100000@fledge.watson.org>
next in thread | previous in thread | raw e-mail | index | archive | help
----- Original Message ----- From: Andrew R. Reiter <arr@FreeBSD.ORG> Newsgroups: lucky.freebsd.audit Sent: Saturday, November 24, 2001 9:51 AM Subject: xtend - unsafe signal handlers patch > Due to "maintainers" lack of responding to my patch to fix some poor > signal handlers in xtend, I figured I should ship it over here for review > (or silence assuming it's ok). The patch is located at: > http://people.freebsd.org/~arr/patches/xtend-signal-warns.diff > I didn't completely check your patch, but it is better to change type of following variables from: +int hup_flag; /* received SIGHUP flag */ +int term_flag; /* received SIGTERM flag */ +int pipe_flag; /* received SIGPIPE flag */ to +volatile sig_atomic_t hup_flag; /* received SIGHUP flag */ +volatile sig_atomic_t term_flag; /* received SIGTERM flag */ +volatile sig_atomic_t pipe_flag; /* received SIGPIPE flag */ I think, because they are changed in signal handlers. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?002101c174c9$02805d60$6d36120a>