Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 28 Aug 2014 13:17:23 +0000
From:      bugzilla-noreply@freebsd.org
To:        freebsd-ports-bugs@FreeBSD.org
Subject:   [Bug 192980] www/squid33 - Wrong option using make config for STRICT_HTTP
Message-ID:  <bug-192980-13-rcH638AWw8@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-192980-13@https.bugs.freebsd.org/bugzilla/>
References:  <bug-192980-13@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=192980

--- Comment #18 from John Marino <marino@FreeBSD.org> ---
(In reply to Lawrence Chen from comment #17)
> There should be a note that this option that used to be enabled by default
> is now disabled by default, so that people wondering why their configuration
> that worked with 3.3.11_4 stopped working with PORTREVISIONS after this.

This is untrue.
The labeling changed.  The option value did not change.  It will built exactly
as before.


> 
> Up to 3.3.11_4
> 
> enabling STRICT_HTTP ==> --disable-http-violations. So OPTIONS_DEFAULT of
> not setting this, mean http-violations were enabled.
> 
> In _5 it was changed to *CONFIGURE_ENABLE=, inverting the behavior and
> inverting the previously inverted logic.  So, not setting STRICT_HTTP
> suddenly meant 'strict_http' was set (as it would disable http violations.)


Again, no behavior was inverted.  It's the same defaults as before.  Had it
been inverted, I would have bumped the port revision.


> 
> Changing the name to LAX_HTTP clarified the relationship of the options knob
> to the configure option, but did not restore the previous default behavior
> that it was enabled.  Or make clear that this was needed to restore things
> to previous defaults.


I don't know what you mean.  Previous to what?  I am talking relative to the
state it was in before the commit.  There is no behavior change.

-- 
You are receiving this mail because:
You are the assignee for the bug.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-192980-13-rcH638AWw8>