Date: Thu, 24 Nov 2005 15:20:19 -0800 (PST) From: Seth Kingsley <sethk@meowfishies.com> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/89513: [MAINTAINER PATCH]: sysutils/bpm crashes on long INDEX lines Message-ID: <20051124232019.743CCDA88D@toxic.magnesium.net> Resent-Message-ID: <200511242330.jAONU2QE043188@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 89513
>Category: ports
>Synopsis: [MAINTAINER PATCH]: sysutils/bpm crashes on long INDEX lines
>Confidential: no
>Severity: non-critical
>Priority: medium
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: maintainer-update
>Submitter-Id: current-users
>Arrival-Date: Thu Nov 24 23:30:02 GMT 2005
>Closed-Date:
>Last-Modified:
>Originator: Seth Kingsley
>Release: FreeBSD 5.4-STABLE i386
>Organization:
>Environment:
System: FreeBSD toxic.magnesium.net 5.4-STABLE FreeBSD 5.4-STABLE #6: Wed Jul 6 13:04:10 PDT 2005 root@toxic.magnesium.net:/data/world/obj/data/world/src/sys/TOXIC i386
>Description:
The BPM utility crashes when the ports INDEX file has lines longer
than 4096 bytes. The current INDEX-5 file has many lines longer than
4K, and one line around 7K. The patch below works around this
problem.
>How-To-Repeat:
Try to run BPM with an updated ports tree.
>Fix:
--- files/patch-src::refresh.c.orig Thu Nov 24 15:12:02 2005
+++ files/patch-src::refresh.c Thu Nov 24 15:12:14 2005
@@ -1,6 +1,6 @@
---- src/refresh.c.orig Mon Aug 23 22:40:08 2004
-+++ src/refresh.c Fri Dec 10 08:58:03 2004
-@@ -62,7 +62,13 @@
+--- src/refresh.c.orig Mon Aug 23 19:40:08 2004
++++ src/refresh.c Thu Nov 24 15:11:48 2005
+@@ -62,8 +62,14 @@
__RCSID("$Id: refresh.c,v 1.32 2004/08/24 02:40:08 sethk Exp $");
/* XXX use libinstall/lib.h */
@@ -10,10 +10,12 @@
+#define INDEX_FN PORTS_BASE "/INDEX-5"
+#else
#define INDEX_FN PORTS_BASE "/INDEX"
+-#define INDEX_MAXLN 4096
+#endif
- #define INDEX_MAXLN 4096
++#define INDEX_MAXLN 8192
#define DB_DIR "/var/db/pkg"
#define ITER_BYTES (128 * 1024)
+ #define ITER_ENTS 32
@@ -183,10 +189,12 @@
if (*sp == '|')
++i;
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20051124232019.743CCDA88D>