Date: Mon, 3 Jun 2019 16:17:09 +0200 From: Niclas Zeising <zeising@freebsd.org> To: Andriy Gapon <avg@FreeBSD.org>, Ian Lepore <ian@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Cc: jmd@freebsd.org Subject: Re: svn commit: r348355 - head/sys/dev/iicbus Message-ID: <72b2ce5e-4c4f-8857-b79b-0b2a412f23fe@freebsd.org> In-Reply-To: <cda9c032-f0ab-7bf5-9d6f-c6167b1cf9ff@FreeBSD.org> References: <201905290908.x4T98L89066643@repo.freebsd.org> <c3f1c60b-24b2-6098-501a-8cb81ef66d57@freebsd.org> <def030c0-80a5-84ca-bb48-7009aa34e69c@FreeBSD.org> <d1128088420c6e52721fb5df2280ca73096bf5c0.camel@freebsd.org> <ac9ae4b6-4b89-1e5f-9116-dcf20fee7e85@freebsd.org> <cda9c032-f0ab-7bf5-9d6f-c6167b1cf9ff@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2019-06-03 14:08, Andriy Gapon wrote: > On 03/06/2019 14:16, Niclas Zeising wrote: >> Hi! >> It seems like things broke after all, latest pkg build (on head-amd64)= reports >> this: >> >> >> /wrkdirs/usr/ports/graphics/drm-legacy-kmod/work/drm-legacy-12bd551/sr= c/dev/drm2/i915/intel_iic.c:570:2: >> error: implicit declaration of function 'iicbus_set_nostop' is invalid= in C99 >> [-Werror,-Wimplicit-function-declaration] >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 iicbus_set_nostop(idev, tr= ue); >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ^ >> /wrkdirs/usr/ports/graphics/drm-legacy-kmod/work/drm-legacy-12bd551/sr= c/dev/drm2/i915/intel_iic.c:570:2: >> error: this function declaration is not a prototype [-Werror,-Wstrict-= prototypes] >> 2 errors generated. >> >> Full log: >> >> http://beefy12.nyi.freebsd.org/data/head-amd64-default/p503023_s348376= /logs/drm-legacy-kmod-g20190523.log >=20 > Hi! Thank you for the report. > I am going to restore iicbus_set_nostop, but this time as a function th= at > modifies iicbus softc (instead of an ivar accessor for the bus). > I am including a patch that I would like to commit. >=20 > However, for the drm code to request the nostop mode correctly it needs= to be > fixed as well. > My proposed patch is here: https://github.com/FreeBSDDesktop/drm-legacy= /pull/9 >=20 Thank you, I will try it out. Will this break drm-legacy-kmod on 12, which doesn't have the iic bus=20 change you proposed? Regards --=20 Niclas Zeising
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?72b2ce5e-4c4f-8857-b79b-0b2a412f23fe>