Date: Sun, 02 Mar 2003 13:18:47 +0000 From: Mark Murray <mark@grondar.org> To: Dag-Erling Smorgrav <des@ofug.org> Cc: Jens Rehsack <rehsack@liwing.de>, Juli Mallett <jmallett@FreeBSD.ORG>, current@FreeBSD.ORG Subject: Re: PATCH: type errors in src-tree Message-ID: <200303021318.h22DIlIg052357@grimreaper.grondar.org> In-Reply-To: Your message of "Sun, 02 Mar 2003 13:08:48 %2B0100." <xzpel5qc6nj.fsf@flood.ping.uio.no>
next in thread | previous in thread | raw e-mail | index | archive | help
Dag-Erling Smorgrav writes: > Jens Rehsack <rehsack@liwing.de> writes: > > Of course. Very often in ilmid.c the type caddr_t was used, and nearly > > the same count of 'const char *'s was used. I've searched the include > > files for caddr_t (core address) and found it defined as 'char *', so > > I decided to used commonly caddr_t - maybe later I check which of them > > could be changed into 'c_caddr_t' for being const. But You can of > > couse replace all 'caddr_t' which 'char *'. > > This is wrong. caddr_t should be uniersally replaced with void *. I'm currently doing this for kicks (Well, actually because it kills a botload of warnings, lint and otherwise). Once make world is working again, I'll put up a patch. My approach is to typedef caddr_t to void*, and then fix the errors this causes. So far, they are all no-brainers; mainly function prototypes that are inconsistent with their definitions. There are a few places where caddr_t is assumed to point to char. M -- Mark Murray iumop ap!sdn w,I idlaH To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200303021318.h22DIlIg052357>