Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 15 Dec 2014 09:47:11 -0500
From:      Ed Maste <emaste@freebsd.org>
To:        "src-committers@freebsd.org" <src-committers@freebsd.org>,  "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>,  "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>
Subject:   Re: svn commit: r275804 - head/gnu/usr.bin/cc/cc1plus
Message-ID:  <CAPyFy2C6aaRrOxzv2WxPH_FKR1zz_TyN04EhDYV-FMXpuXmmxg@mail.gmail.com>
In-Reply-To: <201412151425.sBFEPhhs009026@svn.freebsd.org>
References:  <201412151425.sBFEPhhs009026@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 15 December 2014 at 09:25, Ed Maste <emaste@freebsd.org> wrote:
> Author: emaste
> Date: Mon Dec 15 14:25:42 2014
> New Revision: 275804
> URL: https://svnweb.freebsd.org/changeset/base/275804
>
> Log:
>   Remove empty generated file upon gperf failure
>...
> -           ${.ALLSRC} > ${.TARGET}
> +           ${.ALLSRC} > ${.TARGET} || (rm -f ${.TARGET}; false)

There are additional cases of this potential issue in the tree. In
most cases I examined the target invokes tools that are expected to
exist on the build host (such as sed or awk) so should not be a
problem in practice. There are some cases (gensnmptree, make-roken)
that we may want to revisit as part of a more holistic build
infrastructure project.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAPyFy2C6aaRrOxzv2WxPH_FKR1zz_TyN04EhDYV-FMXpuXmmxg>