Date: Fri, 5 Jan 2018 09:22:43 +0100 From: Rainer Hurling <rhurlin@gwdg.de> To: L.Bartoletti <lbartoletti@tuxfamily.org> Cc: Mathieu Arnold <mat@FreeBSD.org>, <freebsd-ports@freebsd.org> Subject: Re: FLAVOR for Qt4 and Qt5 (was Re: Flavor or not for this port?) Message-ID: <c229b12a-08bb-8073-2a29-a0ce328783c3@gwdg.de> In-Reply-To: <0e444e02-fc35-cfa8-ec36-5d8bbb420124@tuxfamily.org> References: <a181e71d-fdd0-7807-f129-29711c3ee8b5@tuxfamily.org> <46cbd287-186f-9b92-f2a7-d6884c681040@gwdg.de> <37d007c1-0315-5b23-7357-5dc3fcb836fc@gwdg.de> <92d09009-64b3-695a-2282-5acb6ab169f0@tuxfamily.org> <ab612938-9ab0-85f1-eec3-186ff37a719f@tuxfamily.org> <778b4f63-48c7-c717-6c9b-f3ca35c5232c@FreeBSD.org> <0e444e02-fc35-cfa8-ec36-5d8bbb420124@tuxfamily.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi Loïc, Am 04.01.2018 um 18:37 schrieb L.Bartoletti: > Hi Mathieu, > > Thank you for your review and tips. > > I have just submitted the patch. > > Rainer, QGis 2 may be able to use Qwt6 instead of Qwt5? I just tried to use Qwt6 with QGIS2 and it seems to work. A few small tests showed no regressions, so far. If this is true, I could change my port to use qwt6@qt4, once flavors for QWT hit the ports tree. Thanks to both, Loïc and Mathieu, for the work on this. Best wishes, Rainer > > Regards. > > Loïc > > On 21.12.2017 17:10, Mathieu Arnold wrote: >> Le 19/12/2017 à 20:48, L.Bartoletti a écrit : >>> Hi, >>> >>> Here's my WIP >>> >>> https://gitlab.com/lbartoletti/freebsd_ports/tree/master/qwt6 >> As long as you are defining a default FLAVOR value, do it right: >> >> FLAVOR?= ${FLAVORS:[1]} >> >> There are a few stuffs that could be simplified, this works for both >> flavors:| >> >> | >> >> |PLIST= ${PKGDIR}/pkg-plist.${FLAVOR} PLIST_SUB+= >> QT_MKSPECDIR=lib/${FLAVOR}/mkspecs DOCSDIR= >> ${PREFIX}/share/doc/qwt6-${FLAVOR} And this: ||@${REINPLACE_CMD} -e >> 's/__QT_VERSION__/${FLAVOR:S/qt//}/g' >> ${WRKSRC}/qwtconfig.pri| >> || >> >> >> >> You are missing: >> >> qt4_CONFLICTS_INSTALL= qwt6-qt5 >> qt5_CONFLICTS_INSTALL= qwt6-qt4 >> >> >> >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?c229b12a-08bb-8073-2a29-a0ce328783c3>