Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 2 May 2019 02:26:42 +0000 (UTC)
From:      Johannes Lundberg <johalun@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-12@freebsd.org
Subject:   svn commit: r347012 - stable/12/sys/compat/linuxkpi/common/src
Message-ID:  <201905020226.x422Qge2023199@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: johalun
Date: Thu May  2 02:26:42 2019
New Revision: 347012
URL: https://svnweb.freebsd.org/changeset/base/347012

Log:
  MFC r346712:
  Don't call cdev_init where cdev_alloc is called. cdev_alloc already
  handles initialization.
  
  Reviewed by:	hps
  Approved by:	imp (mentor)

Modified:
  stable/12/sys/compat/linuxkpi/common/src/linux_compat.c
Directory Properties:
  stable/12/   (props changed)

Modified: stable/12/sys/compat/linuxkpi/common/src/linux_compat.c
==============================================================================
--- stable/12/sys/compat/linuxkpi/common/src/linux_compat.c	Thu May  2 02:08:26 2019	(r347011)
+++ stable/12/sys/compat/linuxkpi/common/src/linux_compat.c	Thu May  2 02:26:42 2019	(r347012)
@@ -2328,7 +2328,7 @@ __register_chrdev(unsigned int major, unsigned int bas
 
 	for (i = baseminor; i < baseminor + count; i++) {
 		cdev = cdev_alloc();
-		cdev_init(cdev, fops);
+		cdev->ops = fops;
 		kobject_set_name(&cdev->kobj, name);
 
 		ret = cdev_add(cdev, makedev(major, i), 1);
@@ -2350,7 +2350,7 @@ __register_chrdev_p(unsigned int major, unsigned int b
 
 	for (i = baseminor; i < baseminor + count; i++) {
 		cdev = cdev_alloc();
-		cdev_init(cdev, fops);
+		cdev->ops = fops;
 		kobject_set_name(&cdev->kobj, name);
 
 		ret = cdev_add_ext(cdev, makedev(major, i), uid, gid, mode);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201905020226.x422Qge2023199>