Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 03 Jul 2005 01:10:14 -0000
From:      Andrey Chernov <ache@nagual.pp.ru>
To:        Poul-Henning Kamp <phk@phk.freebsd.dk>
Cc:        cvs-src@FreeBSD.ORG, src-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG
Subject:   Re: cvs commit: src/sys/kern sys_generic.c
Message-ID:  <20050125103250.GA29461@nagual.pp.ru>
In-Reply-To: <80763.1106648792@critter.freebsd.dk>
References:  <20050125101457.GA28600@nagual.pp.ru> <80763.1106648792@critter.freebsd.dk>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Jan 25, 2005 at 11:26:32AM +0100, Poul-Henning Kamp wrote:
> Show me code which breaks please.

It is not an argument. Your commit violates both POSIX and SUSv3, namely 
this thing:

"This volume of IEEE Std 1003.1-2001 requires that no action be taken for 
read() or write() when nbyte is zero. This is not intended to take 
precedence over detection of errors (such as invalid buffer pointers or 
file descriptors). This is consistent with the rest of this volume of IEEE 
Std 1003.1-2001, but the phrasing here could be misread to require 
detection of the zero case before any other errors."

I simple don't want to spend time to search code now broken.

If you read my previous message to the end, I already mention the case 
which is obviously broken: FIFOs blocking and EAGAIN returning - it must 
happens for zero byte reads too.

-- 
http://ache.pp.ru/




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050125103250.GA29461>