Date: Fri, 27 Jun 2003 14:25:50 +0000 (UTC) From: naddy@mips.inka.de (Christian Weisgerber) To: freebsd-ports-bugs@freebsd.org Subject: Re: ports/53818: New port: textproc/xmlcatmgr Message-ID: <bdhk5e$13ga$1@kemoauc.mips.inka.de> References: <200306271148.h5RBmqfI099460@alph.allbsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> Xpost-install:
> X @if [ -r ${CATALOG_MASTER_SGML} ]; then\
> X ${WRKSRC}/bin/xmlcatmgr -sc ${CATALOG_MASTER_SGML} add CATALOG
> catalog.ports;\
[...]
So this is only executed when the port is installed, but not when
the corresponding package is installed. I think this behavior is
wrong. The commands should be moved into a pkg-install script,
which will be executed automatically when the package is installed.
For port installs, you can add a post-install target that simply
calls pkg-install.
I would also like to suggest some phrasing improvements:
diff -ur xmlcatmgr.orig/Makefile xmlcatmgr/Makefile
--- xmlcatmgr.orig/Makefile Fri Jun 27 16:20:38 2003
+++ xmlcatmgr/Makefile Fri Jun 27 16:17:30 2003
@@ -62,7 +62,7 @@
${INSTALL_DATA} ${WRKDIR}/catalog.xml ${CATALOG_MASTER_XML};\
fi
@if [ -r ${CATALOG_PORTS_XML} ]; then\
- echo "Skipped: ${CATALOG_PORTS_XML} is already exist.";\
+ echo "Skipped: ${CATALOG_PORTS_XML} already exists.";\
else\
${INSTALL_DATA} ${WRKDIR}/catalog.ports.xml ${CATALOG_PORTS_XML};\
fi
diff -ur xmlcatmgr.orig/pkg-message xmlcatmgr/pkg-message
--- xmlcatmgr.orig/pkg-message Fri Jun 27 16:20:38 2003
+++ xmlcatmgr/pkg-message Fri Jun 27 16:19:39 2003
@@ -3,20 +3,20 @@
1) ${PREFIX}/share/sgml/catalog
The top level catalog for SGML stuff. This is not changed
- by ports/packages but textproc/xmlcatmgr.
+ by any ports or packages except textproc/xmlcatmgr.
2) ${PREFIX}/share/sgml/catalog.ports
- The catalog is for handling SGML stuff installed under
- ${PREFIX}/share/sgml. This is changed by ports/packages.
+ This catalog is for handling SGML stuff installed under
+ ${PREFIX}/share/sgml. It is changed by ports and packages.
3) ${PREFIX}/share/xml/catalog
The top level catalog for XML stuff. This is not changed
- by ports/packages but textproc/xmlcatmgr.
+ by any ports or packages except textproc/xmlcatmgr.
4) ${PREFIX}/share/xml/catalog.ports
- The catalog is for handling XML stuff installed under
- ${PREFIX}/share/xml. This is changed by ports/packages.
+ This catalog is for handling XML stuff installed under
+ ${PREFIX}/share/xml. It is changed by ports and packages.
--
Christian "naddy" Weisgerber naddy@mips.inka.de
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bdhk5e$13ga$1>