Date: Sun, 12 Apr 2009 21:58:04 +0300 From: Vasil Dimov <vd@FreeBSD.org> To: Stanislav Sedov <stas@FreeBSD.org> Cc: svn-src-head@FreeBSD.org, David Schultz <das@FreeBSD.org>, src-committers@FreeBSD.org, Norikatsu Shigemura <nork@FreeBSD.org>, svn-src-all@FreeBSD.org Subject: Re: svn commit: r190943 - head/include Message-ID: <20090412185804.GA53117@polejan.hw.v5d.org> In-Reply-To: <20090411214410.c53d0fb1.stas@FreeBSD.org> References: <200904111657.n3BGvpsC092703@svn.freebsd.org> <20090411210702.ce5325b9.stas@FreeBSD.org> <20090412021841.673a200b.nork@FreeBSD.org> <20090411214410.c53d0fb1.stas@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--vkogqOf2sHV7VnPd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Apr 11, 2009 at 21:44:10 +0400, Stanislav Sedov wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 >=20 > On Sun, 12 Apr 2009 02:18:41 +0900 > Norikatsu Shigemura <nork@FreeBSD.org> mentioned: >=20 > > On Sat, 11 Apr 2009 21:07:02 +0400 > > Stanislav Sedov <stas@freebsd.org> wrote: > > > > Log: > > > > GNU Pth has some fragile kludges that were broken by r189828. > > > > I've discussed this with the Pth maintainer and no clear solution > > > > has emerged on the ports side of things, so for now, hack around > > > > the issue in signal.h. > > > Can't we just put a patch in ports tree itself? What meant under 'no > > > clean solution emerged'? I can prepare a patch, if needed. > >=20 > > I think so, too. I have a quick hack patch. > >=20 > > ports/devel/pth/files/patch-pth_p.h.in > > - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -= - - - - - > > --- pth_p.h.in.orig 2006-06-09 02:54:03.000000000 +0900 > > +++ pth_p.h.in 2009-04-08 15:05:12.911807009 +0900 > > @@ -32,7 +32,7 @@ > > #include <stdarg.h> > > #include <string.h> > > #include <setjmp.h> > > -#include <signal.h> > > +//#include <signal.h> > > #include <unistd.h> > > #include <fcntl.h> > > #include <errno.h> > >=20 > > - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -= - - - - - > >=20 >=20 > Or just drop the line. Vasil, what do you think about the possibility to > commit this patch into the tree? I think we should have a workaround in p= orts > tree (it is one of the things what it was designed for) than in the src t= ree. > Better would be to implement a workaround upstream, though. I think somet= hing > like > #if !(defined(__FreeBSD__) && __FreeBSD_version >=3D %%PTHREAD_CHANGE_VE= RSION%%) > #include <signal.h> > #endif > where %%PTHREAD_CHANGE_VERSION%% would correspond to the __FreeBSD_versio= n where > the change was introduced, could be safely submitted upstream. [...] All, thank you! I have now committed this patch to devel/pth. Lets hope it works :) PS I still do not have access to an 8.0 machine... --=20 Vasil Dimov moc.elcaro@vomid.lisav Software Developer @ Oracle/Innobase Oy gro.DSBeerF@dv Committer @ FreeBSD.org gro.d5v@dv Home @ Sofia, Bulgaria --vkogqOf2sHV7VnPd Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- iEYEARECAAYFAkniObwACgkQFw6SP/bBpCDK0gCg1RJUuiChjljbRTEgfDx1XNby reQAoJAaJJTdM55dhwksq6SqnXcndjzW =oGCt -----END PGP SIGNATURE----- --vkogqOf2sHV7VnPd--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090412185804.GA53117>