Date: Fri, 13 May 2016 00:02:03 +0000 (UTC) From: Don Lewis <truckman@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r299579 - head/usr.sbin/edquota Message-ID: <201605130002.u4D023cS009761@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: truckman Date: Fri May 13 00:02:03 2016 New Revision: 299579 URL: https://svnweb.freebsd.org/changeset/base/299579 Log: Use strlcpy() instead of strncpy() to ensure that qup->fsname is NUL terminated. Don't bother checking for truncation since the subsequent quota_read() should detect that and fail. Reported by: Coverity CID: 1009980 MFC after: 1 week Modified: head/usr.sbin/edquota/edquota.c Modified: head/usr.sbin/edquota/edquota.c ============================================================================== --- head/usr.sbin/edquota/edquota.c Thu May 12 23:37:58 2016 (r299578) +++ head/usr.sbin/edquota/edquota.c Fri May 13 00:02:03 2016 (r299579) @@ -390,7 +390,7 @@ getprivs(long id, int quotatype, char *f if ((qup = (struct quotause *)calloc(1, sizeof(*qup))) == NULL) errx(2, "out of memory"); qup->qf = qf; - strncpy(qup->fsname, fs->fs_file, sizeof(qup->fsname)); + strlcpy(qup->fsname, fs->fs_file, sizeof(qup->fsname)); if (quota_read(qf, &qup->dqblk, id) == -1) { warn("cannot read quotas on %s", fs->fs_file); freeprivs(qup);
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201605130002.u4D023cS009761>