Date: Mon, 01 Sep 2008 17:20:44 +0100 From: Gavin Atkinson <gavin@FreeBSD.org> To: freebsd-sparc64@FreeBSD.org Cc: marius@FreeBSD.org Subject: Re: HEAD panic with ofw_pcibus.c 1.21 on Blade 100 Message-ID: <1220286044.70590.43.camel@buffy.york.ac.uk> In-Reply-To: <1220278827.70590.35.camel@buffy.york.ac.uk> References: <1220278827.70590.35.camel@buffy.york.ac.uk>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 2008-09-01 at 15:20 +0100, Gavin Atkinson wrote:
> Hi all,
>
> My Blade 100 now panics on boot with HEAD, and I've tracked it down to
> sys/sparc64/pci/ofw_pcibus.c 1.21 (SVN r182108) by marius@.
> Specifically, this version now configures bridges differently, and not
> setting "Master Abort Mode" prevents the panic:
>
> Index: src/sys/sparc64/pci/ofw_pcibus.c
> ===================================================================
> RCS file: /home/ncvs/src/sys/sparc64/pci/ofw_pcibus.c,v
> retrieving revision 1.21
> diff -u -r1.21 ofw_pcibus.c
> --- src/sys/sparc64/pci/ofw_pcibus.c 24 Aug 2008 15:05:46 -0000 1.21
> +++ src/sys/sparc64/pci/ofw_pcibus.c 1 Sep 2008 14:09:27 -0000
> @@ -140,7 +140,7 @@
> PCIM_HDRTYPE) == PCIM_HDRTYPE_BRIDGE) {
> reg = PCIB_READ_CONFIG(bridge, busno, slot, func,
> PCIR_BRIDGECTL_1, 1);
> - reg |= PCIB_BCR_MASTER_ABORT_MODE | PCIB_BCR_SERR_ENABLE |
> + reg |= /* PCIB_BCR_MASTER_ABORT_MODE | */ PCIB_BCR_SERR_ENABLE |
> PCIB_BCR_PERR_ENABLE;
> #ifdef OFW_PCI_DEBUG
> device_printf(bridge,
[snip]
> Any suggestions? Are we missing some code necessary to support master
> mode aborts?
After further research (mainly involving eyeballing
pci_pbm_err_handler() in OpenSolaris), it looks like we are indeed
missing code to handle them. Therefore, until this code is written, I
suspect the patch above is actually correct.
Gavin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1220286044.70590.43.camel>