Date: Thu, 27 Mar 2014 09:17:02 -0300 From: Christopher Forgeron <csforgeron@gmail.com> To: Rick Macklem <rmacklem@uoguelph.ca> Cc: FreeBSD Net <freebsd-net@freebsd.org>, Garrett Wollman <wollman@freebsd.org>, Jack Vogel <jfvogel@gmail.com>, Markus Gebert <markus.gebert@hostpoint.ch> Subject: Re: 9.2 ixgbe tx queue hang Message-ID: <CAB2_NwDb27s2nnP_J7EAmkU8Ee4Vc_5-WJq9VwYJsDcU4_nr3Q@mail.gmail.com> In-Reply-To: <1353469098.1239101.1395880303531.JavaMail.root@uoguelph.ca> References: <CAB2_NwA-zLnJh7Teqx4eQ-Tkc8bjx2qL0JMZeZqvSzJZ4mx4cg@mail.gmail.com> <1353469098.1239101.1395880303531.JavaMail.root@uoguelph.ca>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Mar 26, 2014 at 9:31 PM, Rick Macklem <rmacklem@uoguelph.ca> wrote: > > ie. I've suggested: > ifp->if_hw_tsomax = min(32 * MCLBYTES - (ETHER_HDR_LEN + > ETHER_VLAN_ENCAP_LEN), > IP_MAXPACKET); > - I put the min() in just so it wouldn't break if MCLBYTES is increased > someday. > I like the added safety for future changes - Good forward thinking. I'll adjust my testing code to reflect this.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAB2_NwDb27s2nnP_J7EAmkU8Ee4Vc_5-WJq9VwYJsDcU4_nr3Q>