Date: Mon, 29 Aug 2011 14:39:44 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Chris Rees <crees@freebsd.org> Cc: Koop Mast <kwm@freebsd.org>, cvs-ports@freebsd.org, cvs-all@freebsd.org, ports-committers@freebsd.org Subject: Re: cvs commit: ports/textproc/ots Makefile Message-ID: <20110829143944.GA94377@FreeBSD.org> In-Reply-To: <CADLo839MkBrHQRz4B4XRTaSEO51uC%2BXsQXnc3OrZjiMf2Bkkvw@mail.gmail.com> References: <201108261828.p7QISje3085996@repoman.freebsd.org> <20110826200234.GA8743@FreeBSD.org> <CADLo839MkBrHQRz4B4XRTaSEO51uC%2BXsQXnc3OrZjiMf2Bkkvw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Aug 29, 2011 at 02:03:05PM +0100, Chris Rees wrote: > 2011/8/26 Alexey Dokuchaev <danfe@freebsd.org>: > > Just replying to a random MAKE_JOBS_UNSAFE commit. šI have a suggestion > > which I think would help us to fix parallel builds when portmgr@ decides to > > start running -exp runs with forced MAKE_JOBS: every time one of us marks a > > port as MAKE_JOBS_UNSAFE, should provide a short comment on the nature of a > > failure. > > > > Perhaps MAKE_JOBS_UNSAFE knob could be refactored into something similar to > > other "brokenness" knobs and tought to accept a reason string, while "yes" > > value could still be used for cases when exact cause of breakage is not so > > obvious. > > There's no reason a comment can't be put into MAKE_JOBS_UNSAFE; Indeed. I just wasn't sure if it's being checked against "yes" or simply if defined. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20110829143944.GA94377>