Date: Sun, 02 Jul 2000 02:52:04 -0700 From: Julian Elischer <julian@elischer.org> To: Archie Cobbs <archie@whistle.com> Cc: Warner Losh <imp@village.org>, "Andrey A. Chernov" <ache@FreeBSD.org>, Archie Cobbs <archie@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/net if.c if_ethersubr.c if_var.h Message-ID: <395F0CE0.41C67EA6@elischer.org> References: <200007012328.QAA06644@bubba.whistle.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Archie Cobbs wrote: > > Warner Losh writes: > > In message <200007011627.JAA05559@bubba.whistle.com> Archie Cobbs writes: > > : The problem is that the interfaces are not very object oriented > > : (with respect to type), combined with the dynamically loadable code. > > : As an example of the former, all ethernet drivers call if_attach() > > : and ether_attach() when connecting, but only if_detach() when > > : disconnecting. Perhaps they should all only call ether_attach() > > : and ether_detach(). > > > > It should call both. I thought that pccards all did this, but maybe > > I'm mistaken. > > ether_detach() doesn't exist yet.. that's another solution, of > course, to add it and then modify all ethernet drivers to call > ether_detach() right before calling if_detach().. this would be > most consistent with the way things are now I guess. Ethernet drivers should call the ether_* routines which are in their direct parent class. Those, in turn, should call the if_* functions if needed. At least that's the way I see it. > > -Archie > > ___________________________________________________________________________ > Archie Cobbs * Whistle Communications, Inc. * http://www.whistle.com -- __--_|\ Julian Elischer / \ julian@elischer.org ( OZ ) World tour 2000 )_.---._/ presently in: Budapest v To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?395F0CE0.41C67EA6>