Date: Wed, 25 Sep 2013 10:22:00 +0200 From: Olivier Duchateau <duchateau.olivier@gmail.com> To: Frederic Culot <culot@freebsd.org> Cc: "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org>, Danilo Egea Gondolfo <danilo@freebsd.org>, "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>, "ports-committers@freebsd.org" <ports-committers@freebsd.org> Subject: Re: svn commit: r328254 - head/devel/ragel Message-ID: <CAHcdu2qn_2%2BU%2BXPeuO2EtZpmuniGiD3g9SZTinanFGrrwu8SdQ@mail.gmail.com> In-Reply-To: <20130925063916.GF26820@culot.org> References: <201309250524.r8P5Offk027063@svn.freebsd.org> <CAHcdu2piFwZD%2BDSmm4u3EnZ=VCaJ%2BRKEU4J53XwKakXTUvoLVQ@mail.gmail.com> <20130925063916.GF26820@culot.org>
next in thread | previous in thread | raw e-mail | index | archive | help
2013/9/25 Frederic Culot <culot@freebsd.org>:
>
>> > Log:
>> > - Fix build on CURRENT [1]
>> > - Convert USE_GMAKE to USES
>> > - Use options helpers
>> > - Add staging support
>> > - Change maintainer email to @FreeBSD.org
>> >
>> > PR: ports/182240 [1]
>> > Submitted by: Jan Beich <jbeich@tormail.org>
>> > Approved by: culot (mentor)
>>
>> I think Makefile is not well formed.
>>
>> You're replaced ${PREFIX} by ${STAGEDIR}/${PREFIX} (or ${MANPREFIX},
>> ${DOCSDIR}, and ${EXAMPLESDIR}), but ${PREFIX} (and other) already
>> contains /
>>
>> Fix should be ${STAGEDIR}${PREFIX}
>
> Indeed, and sorry I did not catch this.
Try, make -V STAGEDIR -V PREFIX (if STAGEDIR and PREFIX are **not defined**)
you get (something like that)
/usr/ports/devel/ragel/work/stage
/usr/local
When we concatenate, ${STAGEDIR}/${PREFIX} (like in Makefile)
/usr/ports/devel/ragel/work/stage//usr/local
There're 2 // between 'stage' and 'usr'
--
olivier
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAHcdu2qn_2%2BU%2BXPeuO2EtZpmuniGiD3g9SZTinanFGrrwu8SdQ>