Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 18 Oct 2006 20:27:08 GMT
From:      Matt Jacob <mjacob@FreeBSD.org>
To:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   PERFORCE change 108065 for review
Message-ID:  <200610182027.k9IKR8lM000412@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=108065

Change 108065 by mjacob@newisp on 2006/10/18 20:26:36

	ISR reads should have the semaphore and mailbox pointers
	       as pointers to 16 bit quantities- not 32 bit quantities.

Affected files ...

.. //depot/projects/newisp/dev/isp/isp_freebsd.c#13 edit

Differences ...

==== //depot/projects/newisp/dev/isp/isp_freebsd.c#13 (text+ko) ====

@@ -2008,7 +2008,8 @@
 isp_poll(struct cam_sim *sim)
 {
 	ispsoftc_t *isp = cam_sim_softc(sim);
-	uint32_t isr, sema, mbox;
+	uint32_t isr;
+	uint16_t sema, mbox;
 
 	ISP_LOCK(isp);
 	if (ISP_READ_ISR(isp, &isr, &sema, &mbox)) {
@@ -2036,7 +2037,8 @@
 	isp->isp_osinfo.intsok = 0;
 	handle = isp_find_handle(isp, xs);
 	if (handle) {
-		uint32_t isr, sema, mbox;
+		uint32_t isr;
+		uint16_t sema, mbox;
 
 		if (XS_CMD_DONE_P(xs)) {
 			isp_prt(isp, ISP_LOGDEBUG1,
@@ -2352,7 +2354,8 @@
 			break;
 		}
 		for (i = 0; isp->isp_osinfo.leact[seq] && i < 30 * 1000; i++) {
-			uint32_t isr, sema, mbox;
+			uint32_t isr;
+			uint16_t sema, mbox;
 			if (ISP_READ_ISR(isp, &isr, &sema, &mbox)) {
 				isp_intr(isp, isr, sema, mbox);
 			}



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200610182027.k9IKR8lM000412>