Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 2 Mar 2005 11:23:32 +0200
From:      Ruslan Ermilov <ru@freebsd.org>
To:        Tom Rhodes <trhodes@freebsd.org>
Cc:        cvs-all@freebsd.org
Subject:   Re: cvs commit: src/share/man/man5 make.conf.5
Message-ID:  <20050302092332.GA45738@ip.net.ua>
In-Reply-To: <20050302031056.39a44c5a@mobile.pittgoth.com>
References:  <200503020522.j225MRNF036912@repoman.freebsd.org> <20050302074941.GD45034@ip.net.ua> <20050302031056.39a44c5a@mobile.pittgoth.com>

next in thread | previous in thread | raw e-mail | index | archive | help

--6TrnltStXW4iwmi0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi Tom,

On Wed, Mar 02, 2005 at 03:10:56AM -0500, Tom Rhodes wrote:
> On Wed, 2 Mar 2005 09:49:41 +0200
> Ruslan Ermilov <ru@FreeBSD.org> wrote:
>=20
> > On Wed, Mar 02, 2005 at 05:22:27AM +0000, Tom Rhodes wrote:
> > > trhodes     2005-03-02 05:22:27 UTC
> > >=20
> > >   FreeBSD src repository
> > >=20
> > >   Modified files:
> > >     share/man/man5       make.conf.5=20
> > >   Log:
> > >   Document NO_RCMDS, bump doc date.
> > >  =20
> > >   Revision  Changes    Path
> > >   1.118     +10 -1     src/share/man/man5/make.conf.5
> > >=20
> > It looks like a corresponding change to usr.bin/Makefile and
> > friends was forgotten.  :-P
>=20
> Actually, it's:
>=20
> %find . -type file -name "Makefile*" | xargs grep "NO_RCMNDS"
> ./bin/Makefile:.if !defined(NO_RCMNDS)
> ./rescue/rescue/Makefile:.if !defined(NO_RCMNDS)
>=20
> And that should probably be changed to RCMDS to be more
> reasonable.  But it won't be.  Cause no one seems to like
> change.  So I guess I'll fix my commit, and continue what
> I was going to do: wrap all the r* commands in this knob.
>=20
> Unless no one minds, I'd like to just wrap them in NO_RCMDS since
> the former was never documented.  Comments?
>=20
My point was: rlogin(1) and rsh(1) mentioned in this commit
aren't covered by any such knob.  Yet, as you noticed, the
knob is spelled differently -- hence my grep(1) command has
not found it.  :-)

I like the proposal to rename it to a more natural NO_RCMDS,
and adding this knob to usr.bin/Makefile, libexec/Makefile,
etc/rc.d/Makefile, and possibly others.  Please go ahead
with this.


Cheers,
--=20
Ruslan Ermilov
ru@FreeBSD.org
FreeBSD committer

--6TrnltStXW4iwmi0
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (FreeBSD)

iD8DBQFCJYYUqRfpzJluFF4RAhxcAJ4swV8OW9E4xr2khqbeq6ffgQus1gCgkhdA
TA/n5ZjlL5EeFRKkkxljvZc=
=8d6B
-----END PGP SIGNATURE-----

--6TrnltStXW4iwmi0--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050302092332.GA45738>