Date: Wed, 21 Nov 2018 21:42:21 -0600 From: Kyle Evans <kevans@freebsd.org> To: Justin Hibbits <jhibbits@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org, Li-Wen Hsu <lwhsu@freebsd.org> Subject: Re: svn commit: r339516 - head/sys/cddl/dev/dtrace/powerpc Message-ID: <CACNAnaEAGCnrtxyug=FGFneyM6VnAyzNr6Eb5ZDza-z525FRiQ@mail.gmail.com> In-Reply-To: <201810210208.w9L28vVc080088@repo.freebsd.org> References: <201810210208.w9L28vVc080088@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Oct 20, 2018 at 9:09 PM Justin Hibbits <jhibbits@freebsd.org> wrote: > > Author: jhibbits > Date: Sun Oct 21 02:08:57 2018 > New Revision: 339516 > URL: https://svnweb.freebsd.org/changeset/base/339516 > > Log: > powerpc/dtrace: Use explicit bit numbers to mask out PSL_EE > > There seems to be a race in CI, such that dtrace_asm.S might be assembled > before the genassym is completed. This causes a build failure when PSL_EE > doesn't exist, and is read as 0. Get around this by explicitly specifying > the bits in the mask instead. > Hi, CI on the stable/12 branch still hits this, so I'm tempted to MFC this if you don't object. OTOH, the correct solution should be a `dependency "genassym.o"` in ^/sys/conf/files.powerpc for dtrace_asm.S, no? Thanks, Kyle Evans
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CACNAnaEAGCnrtxyug=FGFneyM6VnAyzNr6Eb5ZDza-z525FRiQ>