Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 10 Sep 2002 09:49:33 +0200 (CEST)
From:      Martin Blapp <mb@imp.ch>
To:        Vincent Poy <vince@oahu.WURLDLINK.NET>
Cc:        <current@FreeBSD.ORG>
Subject:   Re: Uncommitted dc0 fixes ...
Message-ID:  <20020910094649.C50626-100000@levais.imp.ch>
In-Reply-To: <20020909130911.U2914-100000@oahu.WURLDLINK.NET>

next in thread | previous in thread | raw e-mail | index | archive | help

Hi,

> 1) dc driver uses wrong case to read MAC from eeprom.
>
> http://www.FreeBSD.org/cgi/query-pr.cgi?pr=kern/35482
>
> This one seems to break data sending/receiving as the only thing that
> works is pinging and that's only on the alias/secondary IP and not the
> primary IP network which is completely unpingable.

I expected this one to be the problem PR. I'll look at it this evening.

+       case DC_DEVICEID_EN2242:     /* and  DC_DEVICEID_EN5251B:  */
     +               if (revision < DC_REVISION_EN5251B) {
     +                       sc->dc_type = DC_TYPE_AN985;
     +               }  else {
     +                       sc->dc_type = DC_TYPE_EN5152B;
     +               }
     +               sc->dc_flags |= DC_TX_USE_TX_INTR;
     +               sc->dc_flags |= DC_TX_ADMTEK_WAR;
     +               sc->dc_pmode = DC_PMODE_MII;
     +               break;
             case DC_DEVICEID_AN985:
     -       case DC_DEVICEID_EN2242:
                     sc->dc_type = DC_TYPE_AN985;
                     sc->dc_flags |= DC_TX_USE_TX_INTR;
                     sc->dc_flags |= DC_TX_ADMTEK_WAR;

This change looks wrong to me.

Martin


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020910094649.C50626-100000>