Date: Sat, 09 Jan 2016 07:57:40 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 206060] Mk/Uses/drupal.mk bug! sets options (comes after bsd.ports.options.mk) Message-ID: <bug-206060-13@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D206060 Bug ID: 206060 Summary: Mk/Uses/drupal.mk bug! sets options (comes after bsd.ports.options.mk) Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: Ports Framework Assignee: portmgr@FreeBSD.org Reporter: marino@FreeBSD.org CC: freebsd-ports-bugs@FreeBSD.org With any drupal port, the new SELECTED_OPTIONS and DESELECTED_OPTIONS are broken. > cd /usr/ports/www/drupal6-token > make showconfig =3D=3D=3D> The following configuration options are available for drupal6-token-6.x.1.12_1: DOCS=3Don: Build and/or install documentation =3D=3D=3D> Use 'make config' to modify these settings make -V SELECTED_OPTIONS -V DESELECTED_OPTIONS (returns 2 blank rows) The cause is because Mk/Uses/drupal.mk is manipulating the options definiti= ons AFTER bsd.port.options.mk is included (and thus *SELECTED_OPTIONS have been evaluated) .if ${_DRUPAL_COMP} _USES_POST+=3D drupal PKGNAMEPREFIX=3D drupal${_DRUPAL_VERSION}- .if defined(DOC_FILES) OPTIONS_DEFINE=3D DOCS .endif # drupal contributions must be licensed under the GPLv2 or GPLv3. This is # documented at: http://drupal.org/licensing/faq/ .if !defined(LICENSE) LICENSE=3D GPLv2 GPLv3 LICENSE_COMB=3D dual .endif After speaking with bdrewery about the idea of relocating the *SELECTED_OPT= IONS evaluations to bsd.port.mk, he indicated that he believed it is an error to= use Mk/Uses to change options and that in his opinion, Drupal is what needs changing. He also pointed out that drupal.mk also makes the mistake of of assigning OPTIONS_DEFINE with "=3D" rather than "+=3D" which overwrites any previous = options definitions (strike two) This PR is to request that DOCS be moved back to the individual ports and secondarily portmgr/documentation guys should specifically document that OPTIONS in Mk/Uses is verboten. --=20 You are receiving this mail because: You are on the CC list for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-206060-13>