Date: Mon, 04 Feb 2013 11:42:31 +0200 From: Andriy Gapon <avg@FreeBSD.org> To: Marko Zec <zec@fer.hr> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, Mark Johnston <markj@FreeBSD.org>, src-committers@FreeBSD.org Subject: Re: svn commit: r246245 - head/sys/netgraph Message-ID: <510F8287.7030708@FreeBSD.org> In-Reply-To: <201302040927.43559.zec@fer.hr> References: <201302021154.r12Bs0tp030831@svn.freebsd.org> <20130204003701.GA1700@oddish> <510F662C.1080007@FreeBSD.org> <201302040927.43559.zec@fer.hr>
next in thread | previous in thread | raw e-mail | index | archive | help
on 04/02/2013 10:27 Marko Zec said the following: > On Monday 04 February 2013 08:41:32 Andriy Gapon wrote: >> + /* Only ethernet interfaces are of interest. */ >> + if (ifp->if_type != IFT_ETHER) >> + return; > > > And what about IFT_FDDI, IFT_XETHER, IFT_ISO88025, IFT_L2VLAN, IFT_BRIDGE, > IFT_ARCNET, IFT_IEEE8023ADLAG, IFT_IEEE80211? Oh, I didn't realize that many drivers changed if_type after if_alloc. Honestly, the networking code is not my strong skill, I ventured here only because nobody else did... So what do you suggest? if_alloctype or a different approach? I'd like to prevent if_l2com being mis-interpreted as struct arpcom. -- Andriy Gapon
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?510F8287.7030708>