Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 7 Apr 2017 12:41:58 +0000 (UTC)
From:      Andrew Turner <andrew@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r316607 - head/crypto/openssl/crypto
Message-ID:  <201704071241.v37Cfw4J043974@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: andrew
Date: Fri Apr  7 12:41:57 2017
New Revision: 316607
URL: https://svnweb.freebsd.org/changeset/base/316607

Log:
  Fix linking with lld by marking OPENSSL_armcap_P as hidden.
  
  Linking with lld fails as it contains a relative address, however the data
  this address is for may be relocated from the shared object to the main
  executable.
  
  Fix this by adding the hidden attribute. This stops moving this value to
  the main executable. It seems this is implicit upstream as it uses a
  version script.
  
  Approved by:	jkim
  Sponsored by:	DARPA, AFRL

Modified:
  head/crypto/openssl/crypto/armcap.c

Modified: head/crypto/openssl/crypto/armcap.c
==============================================================================
--- head/crypto/openssl/crypto/armcap.c	Fri Apr  7 12:27:49 2017	(r316606)
+++ head/crypto/openssl/crypto/armcap.c	Fri Apr  7 12:41:57 2017	(r316607)
@@ -7,6 +7,7 @@
 
 #include "arm_arch.h"
 
+__attribute__ ((visibility("hidden")))
 unsigned int OPENSSL_armcap_P = 0;
 
 #if __ARM_MAX_ARCH__<7



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201704071241.v37Cfw4J043974>