Date: Sat, 17 Aug 1996 09:52:22 +1000 From: Bruce Evans <bde@zeta.org.au> To: imb@asstdc.com.au, julian@whistle.com Cc: current@FreeBSD.org Subject: Re: patch for consideration .. multi-block IDE Message-ID: <199608162352.JAA07932@godzilla.zeta.org.au>
next in thread | raw e-mail | index | archive | help
>What happenned to this? Nothing. >I notice that it's not in -current.. >Bruce, did you veto this or something? I just pointed out all the bugs in the new and old versions. I'll leave it to someone who actually uses multi-mode to fix it. Bugs: 1. No check that the WDCC_SET_MULTI command actually works. Affects all versions. 2. du->dk_multi is never set to anything other than 1, so multi-mode is never used. Affects current version. 3. The proposed patch sets du->dk_multi too early, so the boot message is wrong if multi-mode isn't configured or setting it fails. It isn't easy to print the final setting in the boot message since the final setting isn't decided at attach time. Bruce >> *** /sys/i386/isa/wd.c.orig Sun Jul 28 06:52:04 1996 >> --- /sys/i386/isa/wd.c Wed Aug 7 18:59:08 1996 >> *************** >> *** 1665,1670 **** >> --- 1665,1671 ---- >> du->dk_dd.d_type = DTYPE_ESDI; >> du->dk_dd.d_subtype |= DSTYPE_GEOMETRY; >> #endif >> + du->dk_multi = wp->wdp_nsecperint & 0xff; >> >> return (0); >> }
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199608162352.JAA07932>