Date: Wed, 27 Feb 2019 06:53:10 -0800 From: Cy Schubert <Cy.Schubert@cschubert.com> To: Alexey Dokuchaev <danfe@freebsd.org>,Niclas Zeising <zeising@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r494049 - in head/devel/imake: . files Message-ID: <FF1C3C24-3E8B-4B94-AB7C-212B3C0CE661@cschubert.com> In-Reply-To: <20190227131242.GA6386@FreeBSD.org> References: <201902271255.x1RCtIJs066388@repo.freebsd.org> <20190227131242.GA6386@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Making unrelated changes in the same commit, even when documented, makes pa= rsing of the patch necessary for those who might need to analyze a patch mo= nths after the fact=2E Though painful either way, this is more critical in = src than ports=2E On February 27, 2019 5:12:42 AM PST, Alexey Dokuchaev <danfe@freebsd=2Eorg= > wrote: >On Wed, Feb 27, 2019 at 12:55:18PM +0000, Niclas Zeising wrote: >> New Revision: 494049 >> URL: https://svnweb=2Efreebsd=2Eorg/changeset/ports/494049 >>=20 >> Log: >> devel/imake Add LICENSE > >Could your please not include unrealated changes in the same commit? >Now you've broken svn blaming on these patches, as the real history >would be masked with this "add LICENSE" nonsense which has nothing >to do with them=2E > >=2E/danfe > >> Modified: head/devel/imake/files/patch-imake=2Ec >> >=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D >> --- head/devel/imake/files/patch-imake=2Ec Wed Feb 27 12:06:57 >2019 (r494048) >> +++ head/devel/imake/files/patch-imake=2Ec Wed Feb 27 12:55:18 >2019 (r494049) >> @@ -1,6 +1,6 @@ >> ---- imake=2Ec=2Eorig 2013-07-23 06:53:04=2E000000000 +0200 >> -+++ imake=2Ec 2013-08-31 14:57:48=2E000000000 +0200 >> -@@ -531,6 +531,14 @@ >> +--- imake=2Ec=2Eorig 2013-08-17 10:11:50 UTC >> ++++ imake=2Ec >> +@@ -531,6 +531,14 @@ init(void) >> AddCppArg(p); >> } >> } >> @@ -15,7 +15,7 @@ >> if ((p =3D getenv("IMAKECPP"))) >> cpp =3D p; >> if ((p =3D getenv("IMAKEMAKE"))) >> -@@ -1142,29 +1150,17 @@ >> +@@ -1142,29 +1150,17 @@ get_binary_format(FILE *inFile) >> int mib[2]; >> size_t len; >> int osrel =3D 0; >>=20 >> Modified: head/devel/imake/files/patch-imakemdep=2Eh >> >=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D >> --- head/devel/imake/files/patch-imakemdep=2Eh Wed Feb 27 12:06:57 >2019 (r494048) >> +++ head/devel/imake/files/patch-imakemdep=2Eh Wed Feb 27 12:55:18 >2019 (r494049) >> @@ -1,6 +1,6 @@ >> ---- =2E/imakemdep=2Eh=2Eorig 2012-03-08 06:47:32=2E000000000 +0100 >> -+++ =2E/imakemdep=2Eh 2013-06-12 20:22:52=2E058999526 +0200 >> -@@ -380,7 +383,7 @@ >> +--- imakemdep=2Eh=2Eorig 2013-08-17 10:11:06 UTC >> ++++ imakemdep=2Eh >> +@@ -365,7 +365,7 @@ const char *cpp_argv[ARGUMENTS] =3D { >> defined(__GNUC__) || defined(__GLIBC__) >> # ifdef __i386__ >> "-D__i386__", >>=20 --=20 Pardon the typos and autocorrect, small keyboard in use=2E Cheers, Cy Schubert <Cy=2ESchubert@cschubert=2Ecom> FreeBSD UNIX: <cy@FreeBSD=2Eorg> Web: http://www=2EFreeBSD=2Eorg The need of the many outweighs the greed of the few=2E
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?FF1C3C24-3E8B-4B94-AB7C-212B3C0CE661>