Date: Thu, 03 Dec 2015 09:00:51 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 204943] usr/src/sbin/newfs_msdos/mkfs_msdos.c:586: memory leak ? Message-ID: <bug-204943-8-qWIBWwPwaW@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-204943-8@https.bugs.freebsd.org/bugzilla/> References: <bug-204943-8@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=204943 --- Comment #4 from David Binderman <dcb314@hotmail.com> --- >Although this fix is not wrong as such, fixing the memory leak in this >extremely rare error case does not make much sense if the happy path and error >cases that may actually happen still leak the memory. True, but if there were leaks on the main path, I'd have reported them before a leak on an error path. More detail: $ ~/cppcheck/trunk/cppcheck --enable=all usr/src/sbin/newfs_msdos/mkfs_msdos.c Checking usr/src/sbin/newfs_msdos/mkfs_msdos.c... [usr/src/sbin/newfs_msdos/mkfs_msdos.c:586]: (error) Memory leak: img $ I see no evidence of any other memory leaks, or any other detectable problems, in the source code file. A patch for the leak has been produced, problem closed AFAIK. -- You are receiving this mail because: You are the assignee for the bug.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-204943-8-qWIBWwPwaW>