Date: 14 Feb 2000 21:08:39 -0000 From: okazaki@be.to To: FreeBSD-gnats-submit@freebsd.org Subject: ports/16716: Fix port: devel/portlint Message-ID: <20000214210839.11169.qmail@dolphin.be.to>
next in thread | raw e-mail | index | archive | help
>Number: 16716
>Category: ports
>Synopsis: Fix port: devel/portlint
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Mon Feb 14 13:10:01 PST 2000
>Closed-Date:
>Last-Modified:
>Originator: OKAZAKI Tetsurou
>Release: FreeBSD 3.4-STABLE i386
>Organization:
Unknown
>Environment:
ports/devel/portlint/src/portlint.pl,v 1.14 2000/02/02 21:07:39
>Description:
Current portlint keeps quiet about some invalid `CATEGORIES' lines.
>How-To-Repeat:
1. Move to a simple port directory, for a example:
% cd ${PORTSDIR}/archives/arc
2. Damage his Makefile as follows:
% perl -pi -e 's/^CATEGORIES[+?]?=.*/CATEGORIES/g' Makefile
3. And listen to the portlint talking:
% portlint
OK: checking pkg/COMMENT.
OK: checking pkg/DESCR.
OK: checking Makefile.
OK: checking files/md5.
OK: checking patches/patch-aa.
OK: checking patches/patch-ab.
OK: checking patches/patch-ac.
looks fine.
>Fix:
Apply the following patch.
diff -urN /usr/ports/devel/portlint/src/portlint.pl portlint/src/portlint.pl
--- /usr/ports/devel/portlint/src/portlint.pl Thu Feb 3 17:32:24 2000
+++ portlint/src/portlint.pl Tue Feb 15 00:17:44 2000
@@ -688,7 +688,7 @@
"not by \"$1\".");
}
print "OK: checking CATEGORIES.\n" if ($verbose);
- if ($tmp !~ /\nCATEGORIES(?=)/) {
+ if ($tmp !~ /\nCATEGORIES([+?]?=)/) {
&perror("FATAL: CATEGORIES has to be there.");
}
if ($tmp =~ /\nCATEGORIES([^?+]=)/) {
>Release-Note:
>Audit-Trail:
>Unformatted:
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20000214210839.11169.qmail>