Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 1 Feb 2021 12:40:46 GMT
From:      Mateusz Guzik <mjg@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org
Subject:   git: 7ba12ba0a2df - stable/13 - zfs: use atomic_load_consume_ptr for z_cached_symlink
Message-ID:  <202102011240.111CekWc096881@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch stable/13 has been updated by mjg:

URL: https://cgit.FreeBSD.org/src/commit/?id=7ba12ba0a2df573d055c7f088e666d86e4fea898

commit 7ba12ba0a2df573d055c7f088e666d86e4fea898
Author:     Mateusz Guzik <mjg@FreeBSD.org>
AuthorDate: 2021-01-25 20:15:19 +0000
Commit:     Mateusz Guzik <mjg@FreeBSD.org>
CommitDate: 2021-02-01 12:39:16 +0000

    zfs: use atomic_load_consume_ptr for z_cached_symlink
    
    (cherry picked from commit 7af02ef0b222eebad4827a264454e85134692e94)
---
 sys/contrib/openzfs/module/os/freebsd/zfs/zfs_vnops_os.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/sys/contrib/openzfs/module/os/freebsd/zfs/zfs_vnops_os.c b/sys/contrib/openzfs/module/os/freebsd/zfs/zfs_vnops_os.c
index 1ee0895625a6..42f5786ce5c7 100644
--- a/sys/contrib/openzfs/module/os/freebsd/zfs/zfs_vnops_os.c
+++ b/sys/contrib/openzfs/module/os/freebsd/zfs/zfs_vnops_os.c
@@ -4476,10 +4476,7 @@ zfs_freebsd_fplookup_symlink(struct vop_fplookup_symlink_args *v)
 		return (EAGAIN);
 	}
 
-	/*
-	 * FIXME: Load consume would be sufficient but there is no primitive to do it.
-	 */
-	target = (char *)atomic_load_acq_ptr((uintptr_t *)&zp->z_cached_symlink);
+	target = atomic_load_consume_ptr(&zp->z_cached_symlink);
 	if (target == NULL) {
 		return (EAGAIN);
 	}



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202102011240.111CekWc096881>