Date: Sun, 7 Apr 2002 15:27:16 +0200 From: Philipp Mergenthaler <un1i@rz.uni-karlsruhe.de> To: =?iso-8859-1?Q?S=F8ren?= Schmidt <sos@freebsd.dk> Cc: freebsd-hackers@FreeBSD.ORG, maxim@macomnet.ru Subject: Re: cdcontrol(1) speed command Message-ID: <20020407132716.GA3437@rz.uni-karlsruhe.de> In-Reply-To: <200204051431.g35EV5b33064@freebsd.dk> References: <E16tTvt-0002NJ-00@rzstud1.rz.uni-karlsruhe.de> <200204051431.g35EV5b33064@freebsd.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Apr 05, 2002 at 04:31:04PM +0200, S=F8ren Schmidt wrote: > It seems Philipp Mergenthaler wrote: > > > @@ -24,6 +24,7 @@ > > > #endif /* not lint */ > >=20 > > > #include <sys/cdio.h> > > > +#include <sys/cdrio.h> > >=20 > > J=F6rg Wunsch commented that adding "include <sys/cdrio.h>" would be > > wrong and that this ioctl should be moved to sys/cdio.h instead. > > (I guess then it should be renamed to CDIOCREADSPEED, too.) > > This would then have to be changed in src/sys/dev/ata/atapi-cd.c, too. >=20 > Hmm, then the functionality should be added to the SCSI CD driver > first, until then its only for ATAPI CDROM's, and should stay > where it is, to not break binary compatibility.. Ok, kern/36845 adds this to the SCSI driver. I don't have a SCSI CD drive to test with, but it works with my ATAPI drive + ATAPICAM, FWIW :-). What's the best way to proceed? Should Maxim commit the change to cdcontrol as it is and i'll wait until kern/36845 is committed and then send-pr a patch which moves this ioctl from cdio.h to cdrio.h and renames it? (And also in atapi-cd.c, scsi-cd.c and cdcontrol.c) Thanks, Philipp To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020407132716.GA3437>