Date: Thu, 8 Nov 2018 13:14:45 +0300 From: Lev Serebryakov <lev@FreeBSD.org> To: Oleg Bulyzhin <oleg@FreeBSD.org>, freebsd-net@FreeBSD.org Subject: Re: ix0 (iflib) vlans @ head & 12-stable Message-ID: <417ecc04-783f-2ecd-d0bf-66510168ca51@FreeBSD.org> In-Reply-To: <20181108101124.GB80723@lath.rinet.ru> References: <20181108101124.GB80723@lath.rinet.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --0PQUDKYqXHB1o8xz8ezpHZFRWUXvysZ4o Content-Type: multipart/mixed; boundary="dTmhz5JagI5sj3guhhPLeDMG53THYKlso"; protected-headers="v1" From: Lev Serebryakov <lev@FreeBSD.org> Reply-To: lev@FreeBSD.org To: Oleg Bulyzhin <oleg@FreeBSD.org>, freebsd-net@FreeBSD.org Message-ID: <417ecc04-783f-2ecd-d0bf-66510168ca51@FreeBSD.org> Subject: Re: ix0 (iflib) vlans @ head & 12-stable References: <20181108101124.GB80723@lath.rinet.ru> In-Reply-To: <20181108101124.GB80723@lath.rinet.ru> --dTmhz5JagI5sj3guhhPLeDMG53THYKlso Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 08.11.2018 13:11, Oleg Bulyzhin wrote: > current ixgbe driver is using iflib and has IFCAP_VLAN_HWFILTER > enabled by default. >=20 > /sys/net/iflib.c iflib_vlan_[un]register() functions have this code: >=20 > /* Re-init to load the changes */ > if (if_getcapenable(ifp) & IFCAP_VLAN_HWFILTER) > iflib_if_init_locked(ctx); >=20 > Thus any vlan reconfiguration leads to link flap. This is not > how it was before iflib conversion. On 12 each cpability reconfiguration for em/igb/ix leads to link flap, where 11 doesn't need this flap for most of capabilities of these cards. IMHO, it is regression. --=20 // Lev Serebryakov --dTmhz5JagI5sj3guhhPLeDMG53THYKlso-- --0PQUDKYqXHB1o8xz8ezpHZFRWUXvysZ4o Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEE+W0coLX0MYtnSzMK6rA8WL/cR48FAlvkDJVfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEY5 NkQxQ0EwQjVGNDMxOEI2NzRCMzMwQUVBQjAzQzU4QkZEQzQ3OEYACgkQ6rA8WL/c R48dsBAAsAPd4sAHp1uK77ZvZlfbFONHMTadrRt/c1eiTWdvrcrgyh3X8f2SMHDC m0yasEjo2tgRtSlcYlcfpPtW7UNl98QtMRIOaUbDwPXigiWwyu2m1nqBh/KDFRO7 9qX/GGpGBVpiA+q2DiTz5i1zVgTx9vJl3/ggbFBM3LLNLtor3aq69XWaplIFLJ14 E2F+AUreHf1Pkhb8ZaRY0s/huprYeNH25jze9EXQwKkqk4vFI/TS0KCk5Hfd46+K X/9O3vNL6RnaWOTf1zzaTa6jmjaSjpC5rQejKZSk67vyqS1V3cz7s2hzGDnnEPfN 8/fM2tK+6CIdGpkXfVVsjjtH5X4o5YpyY7bHimUjUJcEyIGBm0JYI05oE9DQ0mUe S/JyHzuuBWWvKpb/Gq7hyDbHq5UbLotFQ+7VCN+sGhcp69ON+yZQtsCagYmMbAz2 0e+szR6yH0xxNphQJ4TdJEXJ3AbPr9wD++lB7F+MChFYghl+cJaUTa20ki5n29kD mKnJrW1QOUXn00iC5/55lKAl8upUC0xjyGH8pcuGtaZImwz5EUZt21scrw+uiEUQ f/5N7H/AQjoNnS8wbK6DpyQAb/EQoWqil4MVyzntJkYHc5U6qq72WCEttZrO5sVk zTWSenWetqU0iUP4qWN4arT1ZVRUKVEh8uUXEueZp8KeLU7SdiY= =o9vL -----END PGP SIGNATURE----- --0PQUDKYqXHB1o8xz8ezpHZFRWUXvysZ4o--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?417ecc04-783f-2ecd-d0bf-66510168ca51>