Date: Thu, 8 Oct 2020 04:34:47 -0600 From: Adam Weinberger <adamw@adamw.org> To: Piotr Kubaj <pkubaj@anongoth.pl> Cc: ports-committers <ports-committers@freebsd.org>, svn-ports-all <svn-ports-all@freebsd.org>, svn-ports-head <svn-ports-head@freebsd.org> Subject: Re: svn commit: r551634 - head/databases/postgresql13-server Message-ID: <CAP7rwci=m-0q9A7XN-MFymP_Q54G7CrzCsb907H4HisUC6%2BM5A@mail.gmail.com> In-Reply-To: <20201008102448.GA35539@KGPE-D16> References: <202010071306.097D6JOj080863@repo.freebsd.org> <CAP7rwcgpFhJB2d09XuvpOQ%2B09OPZoW%2BOXbtQTrqEp22=qJFKJA@mail.gmail.com> <20201008102448.GA35539@KGPE-D16>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Oct 8, 2020 at 4:24 AM Piotr Kubaj <pkubaj@anongoth.pl> wrote: > > It was previously committed in https://svnweb.freebsd.org/ports?view=revision&revision=527871 and it seemed to work. Or is it that just no one noticed it? > > I'm trying to understand why this issue appeared and how to fix it without reverting to the previous (also broken) behaviour. The problem happens because of the extra level of indirection. The ${CHOSEN_COMPILER_TYPE} causes it to be evaluated too late, overwriting PORT_OPTIONS. As to why it wasn't happening before, I'm not sure. Why not just exclude it on gcc archs instead? OPTIONS_DEFINE= ... LLVM OPTIONS_EXCLUDE_fooarch= LLVM I can certainly appreciate the clever approach you're taking here, but it's apparently too clever for options.mk. # Adam > On 20-10-08 04:11:05, Adam Weinberger wrote: > > On Wed, Oct 7, 2020 at 7:06 AM Piotr Kubaj <pkubaj@freebsd.org> wrote: > > > > > > Author: pkubaj > > > Date: Wed Oct 7 13:06:19 2020 > > > New Revision: 551634 > > > URL: https://svnweb.freebsd.org/changeset/ports/551634 > > > > > > Log: > > > databases/postgresql13-server: fix build on GCC architectures > > > > > > Add the previously removed disabling of LLVM when it's not in base. > > > > > > > +OPTIONS_DEFAULT+= ${OPTIONS_DEFAULT_${CHOSEN_COMPILER_TYPE}} > > > +OPTIONS_DEFAULT_clang= LLVM > > > > This forces the LLVM option on for all clang users, and prevents it > > from ever getting turned off. Please, turn the LLVM forcing off. -- Adam Weinberger adamw@adamw.org https://www.adamw.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAP7rwci=m-0q9A7XN-MFymP_Q54G7CrzCsb907H4HisUC6%2BM5A>