Date: Sat, 29 Oct 2005 00:03:24 -0400 From: John Baldwin <jhb@FreeBSD.org> To: Bill Paul <wpaul@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/txp if_txp.c Message-ID: <200510290003.25709.jhb@FreeBSD.org> In-Reply-To: <200510290301.j9T31H3P083494@repoman.freebsd.org> References: <200510290301.j9T31H3P083494@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Friday 28 October 2005 11:01 pm, Bill Paul wrote: > wpaul 2005-10-29 03:01:17 UTC > > FreeBSD src repository > > Modified files: > sys/dev/txp if_txp.c > Log: > Remove call to txp_set_filter() from txp_attach(). txp_set_filter() nee= ds > the ifp, so you can't call it before doing if_alloc(). Also, there's > really no need to call it here anyway: the code I originally ported from > OpenBSD incorrectly set the station address only once at device attach > time, instead of setting in txp_init(). This meant you couldn't change > the address with ifconfig txp0 ether xx:xx:xx:xx:xx:xx. I added the > call to txp_set_filter() in txp_init() to correct this, but forgot to > remove the call from txp_attach(). Until now, it never mattered. > > With this fix, the txp driver tests good: > > txp0: <3Com 3cR990-TX-97 Etherlink with 3XP Processor> port 0xb800-0xb8= 7f > mem 0xe6800000-0xe683ffff irq 12 at device 10.0 on pci0 txp0: Ethernet > address: 00:01:03:d4:91:4f Thanks again for testing and fixing the bogons. =2D-=20 John Baldwin <jhb@FreeBSD.org> =A0<>< =A0http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" =A0=3D =A0http://www.FreeBSD.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200510290003.25709.jhb>