Date: Tue, 7 May 2013 13:27:24 -0700 From: Garrett Cooper <yanegomi@gmail.com> To: Xin LI <d@delphij.net> Cc: "freebsd-arch@FreeBSD.org Arch" <freebsd-arch@freebsd.org>, freebsd-toolchain@freebsd.org, "Simon J. Gerraty" <sjg@juniper.net> Subject: Re: [RFC] adding a variable to .mk and Makefile.inc1 to point to top of the FreeBSD source tree Message-ID: <CAGH67wTyBHcqv%2B_cDVPXyX8=hCoAcXy4B3oOy6-dTQHybPvNQw@mail.gmail.com> In-Reply-To: <51896021.6010900@delphij.net> References: <CAGH67wS21otQr1fBqQ2z=XQjUV30QUjdtyAkzC_Tf1Ts%2BPq%2B8g@mail.gmail.com> <51896021.6010900@delphij.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, May 7, 2013 at 1:12 PM, Xin Li <delphij@delphij.net> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA512
>
> On 05/07/13 13:05, Garrett Cooper wrote:
> > Hi, A common pattern that I've seen at Isilon and something else
> > that I've wanted to have for a while is the ability to designate
> > where the top of a source tree was. This is important and helpful
> > when dealing with source files that build upon each other or depend
> > on sources located in other sections of the tree; contrib stuff
> > needs to set .PATH appropriately to point to sources at the top of
> > the tree, sys stuff is riddled with S= in order to point to where
> > /sys, etc lives, we build upon FreeBSD within an expected directory
> > structure as well. I haven't come up with a name, but was wondering
> > if this was a good idea, and if so does anyone have any outstanding
> > patches for this that can be pushed into FreeBSD?
>
> Is there anything wrong with the current '../../' approach?
>
Not in particular, other than our variable (ISI_TOP) is used in
referencing ${.CURDIR} and ${.OBJDIR}, and it's easy to make mistakes if
you goof up the dot-dots. With a properly defined directory like that it
makes things unambiguous in my mind and with a proper name it makes pathing
more intuitive than it currently is. Besides, it would make some other
things cleaner, like the dot-dot magic that config(8), etc does.
Thanks!
-Garrett
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGH67wTyBHcqv%2B_cDVPXyX8=hCoAcXy4B3oOy6-dTQHybPvNQw>