Date: Thu, 25 Aug 2011 01:22:55 +0200 From: Gabor Kovesdan <gabor@FreeBSD.org> To: Andrey Chernov <ache@freebsd.org>, src-committers@FreeBSD.ORG, svn-src-user@FreeBSD.ORG Subject: Re: svn commit: r225093 - in user/gabor/tre-integration: contrib/tre/lib include Message-ID: <4E5587CF.2010309@FreeBSD.org> In-Reply-To: <20110823034416.GA7597@vniz.net> References: <201108222319.p7MNJKZ4072487@svn.freebsd.org> <20110823034416.GA7597@vniz.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2011.08.23. 5:44, Andrey Chernov wrote:
> On Mon, Aug 22, 2011 at 11:19:20PM +0000, Gabor Kovesdan wrote:
>> Modified: user/gabor/tre-integration/include/regex.h
>> ==============================================================================
>> --- user/gabor/tre-integration/include/regex.h Mon Aug 22 23:15:15 2011 (r225092)
>> +++ user/gabor/tre-integration/include/regex.h Mon Aug 22 23:19:20 2011 (r225093)
>> @@ -110,6 +110,7 @@ typedef enum {
>> #define REG_PEND (REG_UNGREEDY<< 1)
>> #define REG_GNU (REG_PEND<< 1)
>> #define REG_WORD (REG_GNU<< 1)
>> +#define _REG_HEUR (REG_WORD<< 1)
> Not a good place. Next extension flag from TRE author or POSIX will break
> binary compatibility badly. It will be better to put it to the end of a
> word instead or don't use this field at all (converting to another
> internal function argument etc.), which is much safer.
Thanks for reviewing my changes and commenting!
This change was a semi-temporary solution. I'm wondering whether I
should remove the underscore and consider it a normal knob as it may be
useful outside TRE, however I cannot think of any concrete case. What do
you exactly mean by end of a word? Still, binary compatibility will
break if a new POSIX flag will be introduced because TRE already defines
some extra flags. I'm not quite sure which is the best solution.
Probably, I'll clean up my patches once I'm done and hopefully the TRE
author will be interested in integrating my changes so I'll discuss
these with him.
Gabor
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4E5587CF.2010309>