Date: Thu, 22 Apr 2021 10:56:52 +0000 From: Alexey Dokuchaev <danfe@freebsd.org> To: Mathieu Arnold <mat@freebsd.org> Cc: Michael Gmelin <grembo@freebsd.org>, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 5b7c17856512 - main - git hooks: Rework authorship instructions. Message-ID: <YIFWdO5pTJCu45qa@FreeBSD.org> In-Reply-To: <20210422104914.d3kwtrwl2jovwvu2@aching.in.mat.cc> References: <YIFK/tIpcfqWTWVh@FreeBSD.org> <FB32E75F-9AF0-41C2-9EE1-B10D931DECD0@freebsd.org> <20210422101616.c3i7dn6gfm6hhner@aching.in.mat.cc> <YIFTYpPMe43y6tU9@FreeBSD.org> <20210422104914.d3kwtrwl2jovwvu2@aching.in.mat.cc>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Apr 22, 2021 at 12:49:14PM +0200, Mathieu Arnold wrote: > On Thu, Apr 22, 2021 at 10:43:46AM +0000, Alexey Dokuchaev wrote: > > On Thu, Apr 22, 2021 at 12:16:16PM +0200, Mathieu Arnold wrote: > > > On Thu, Apr 22, 2021 at 12:10:26PM +0200, Michael Gmelin wrote: > > > > ... > > > > I agree that author should only be used if a submission is applied > > > > unaltered (pull request/git patch). > > > > > > Submitted by has always been for submission that was unaltered (or only > > > slightly altered) if it was only the basis of the work, then "submitted > > > by" is not to be used, in those cases, reported by is the correct > > > choice. > > > > Not really, no. "PR:/Submitted by:" is canonical combination, yet most > > of us modify submitted patches because they almost always need more work. > > Then you are misusing Submitted by. Submitted by was supposed to be > used when you committed something that was, well, submitted by someone > else. If the work is yours, and that you based your work on someone > else's, then, it is not submitted by them. No: "submitted" literally means there was actionable submission, i.e. a patch. It could be good enough to be committed as is (rarely), or require various amounts of polishing. Regardless of its quality, it is still not merely a "report" as you would suggest. "Reports" are sent by portscout or pkg-fallout. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?YIFWdO5pTJCu45qa>