Date: Tue, 6 May 2014 18:01:54 +0200 From: Marius Strobl <marius@alchemy.franken.de> To: Hans Petter Selasky <hps@selasky.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers <src-committers@freebsd.org>, Warner Losh <imp@bsdimp.com> Subject: Re: svn commit: r265359 - head/sys/modules/sound/sound Message-ID: <20140506160154.GA679@alchemy.franken.de> In-Reply-To: <53690381.9040909@selasky.org> References: <201405051431.s45EVZ2q027729@svn.freebsd.org> <7745BD19-5BAE-47BD-8DE4-10CF7E23FA9D@gmail.com> <53690381.9040909@selasky.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, May 06, 2014 at 05:45:05PM +0200, Hans Petter Selasky wrote: > On 05/05/14 22:39, Warner Losh wrote: > > > > On May 5, 2014, at 8:31 AM, Hans Petter Selasky <hselasky@freebsd.org> wrote: > > > >> Author: hselasky > >> Date: Mon May 5 14:31:34 2014 > >> New Revision: 265359 > >> URL: http://svnweb.freebsd.org/changeset/base/265359 > >> > >> Log: > >> Build the kernel sound module without ISA DMA support for ARM and MIPS > >> platforms, because these platforms do not implement the ISA DMA > >> API. Else the sound modules cannot be loaded when running these > >> platforms. > >> > >> MFC after: 2 weeks > >> > >> Modified: > >> head/sys/modules/sound/sound/Makefile > >> > >> Modified: head/sys/modules/sound/sound/Makefile > >> ============================================================================== > >> --- head/sys/modules/sound/sound/Makefile Mon May 5 11:50:52 2014 (r265358) > >> +++ head/sys/modules/sound/sound/Makefile Mon May 5 14:31:34 2014 (r265359) > >> @@ -44,7 +44,8 @@ CLEANFILES+= feeder_eq_gen.h feeder_rate > >> > >> EXPORT_SYMS= YES # XXX evaluate > >> > >> -.if ${MACHINE_CPUARCH} == "sparc64" || ${MACHINE_CPUARCH} == "powerpc" > >> +.if ${MACHINE_CPUARCH} == "sparc64" || ${MACHINE_CPUARCH} == "powerpc" || \ > >> + ${MACHINE_CPUARCH} == "arm" || ${MACHINE_CPUARCH} == "mips" > >> # Create an empty opt_isa.h in order to keep kmod.mk from linking in an > >> # existing one from KERNBUILDDIR which possibly has DEV_ISA defined so > >> # sound.ko is always built without isadma support. > > > > Rather than an opt-in approach here, why not lust list the three that have it since > > they are the only ones that will ever have it? > > > > Warner > > > > Hi, > > Maybe the sound DMA file belongs in its own module? > It's not just sndbuf_dma.c but also the #ifdef'ed DEV_ISA code in channel.c on architectures that have ISA but not ISA DMA support, hence the current kludge. Marius
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140506160154.GA679>