Date: Sat, 13 Jul 2002 21:32:56 -0700 (PDT) From: Don Lewis <dl-freebsd@catspoiler.org> To: fenner@research.att.com Cc: hsu@FreeBSD.org, dl-freebsd@catspoiler.org, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/netinet udp_usrreq.c Message-ID: <200207140433.g6E4Wuwr020201@gw.catspoiler.org> In-Reply-To: <200207140407.VAA18366@windsor.research.att.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 13 Jul, Bill Fenner wrote: > >> > The inp->inp_socket == NULL check shows up in the code >> > listing in _TCP/IP Illustrated Volume 2_, but there doesn't seem to be >> > any need for it there. It probably slipped in to "fix" panic some time >> > in the deep dark past when there were probably locking problems in the >> > code. >> >>This is where the CSRG SCCS archive comes in real handy. > > There is no "inp->inp_socket == NULL" in rev 8.6 (or any previous rev) > of udp_usrreq.c . It's in in_pcbnotify() in rev 1.1.1.1 of in_pcb.c in the FreeBSD CVS repository, which is the BSD 4.4 Lite import, and claims to be: * @(#)in_pcb.c 8.2 (Berkeley) 1/4/94 This code, including the "inp->inp_socket == NULL" check was migrated to tcp_ctlinput() in rev 1.94 of tcp_subr.c. It was also migrated to udp_ctlinput() in rev 1.87 of udp_usrreq.c. I previously thought that the "inp->inp_socket == NULL" check was lost when this code was imported into udp_ctlinput(), but I was incorrect. I dug through the repo and this check went away between revs 1.110 and 1.111 of udp_usrreq.c. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200207140433.g6E4Wuwr020201>