Date: Sat, 29 May 2004 19:05:56 -0700 From: Kris Kennaway <kris@obsecurity.org> To: Yen-Ming Lee <leeym@FreeBSD.org> Cc: ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/net/GeoIP Makefile distinfo pkg-message pkg-plist ports/net/GeoIP/files patch-ltmain.sh Message-ID: <20040530020556.GB5773@xor.obsecurity.org> In-Reply-To: <200405292314.i4TNEVlb048366@repoman.freebsd.org> References: <200405292314.i4TNEVlb048366@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--5I6of5zJg18YgZEa
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
On Sat, May 29, 2004 at 04:14:31PM -0700, Yen-Ming Lee wrote:
> | - @${CAT} ${PKGMESSAGE}
> | +.if !exists(${PREFIX}/etc/GeoIP.conf.default)
> | + @${CP} ${PREFIX}/etc/GeoIP.conf.default ${PREFIX}/etc/GeoIP.conf
> | +.endif
What about when this is installed from the package? This should be an
@exec in the pkg-plist. You only did the other half (removal):
> | +@unexec if cmp -s %D/etc/GeoIP.conf %D/etc/GeoIP.conf.default; then rm -f %D/etc/GeoIP.conf; fi
> | +++ ports/net/GeoIP/distinfo 2004/05/29 23:14:31 1.14
> | @@ -1,2 +1,3 @@
> | -MD5 (GeoIP-1.2.2.tar.gz) = 6844bee99c6426924a11b1998460e6f6
> | +MD5 (GeoIP-1.3.1.tar.gz) = cbfb7be70e2b02140677008d6e902dac
> | +SIZE (GeoIP-1.3.1.tar.gz) = 526429
> | SIZE (GeoIP-1.2.2.tar.gz) = 512557
You forgot to remove the old SIZE. Running 'make makesum' would have
done this automatically.
Kris
--5I6of5zJg18YgZEa
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (FreeBSD)
iD8DBQFAuUGEWry0BWjoQKURAiWvAKCB3yGgY8bm5Lmu8gvqw1zInzxRjQCfYITk
/RvfrjjlX++KmNQIJHSQE3I=
=b5gM
-----END PGP SIGNATURE-----
--5I6of5zJg18YgZEa--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040530020556.GB5773>