Date: Thu, 17 Oct 2002 03:07:07 +0900 From: JINMEI Tatuya / =?ISO-2022-JP?B?GyRCP0BMQEMjOkgbKEI=?= <jinmei@isl.rdc.toshiba.co.jp> To: Luigi Rizzo <rizzo@icir.org> Cc: Sam Leffler <sam@errno.com>, Julian Elischer <julian@elischer.org>, freebsd-arch@FreeBSD.ORG, freebsd-net@FreeBSD.ORG Subject: Re: CFR: m_tag patch Message-ID: <y7vadle2r78.wl@ocean.jinmei.org> In-Reply-To: <20021016074610.C34626@carp.icir.org> References: <Pine.BSF.4.21.0210071613260.34884-100000@InterJet.elischer.org> <18d301c26e5e$8b5c7a30$52557f42@errno.com> <y7vd6qhg0vj.wl@ocean.jinmei.org> <080101c27151$b2e92a30$52557f42@errno.com> <y7vbs5u4s5m.wl@ocean.jinmei.org> <20021016074610.C34626@carp.icir.org>
next in thread | previous in thread | raw e-mail | index | archive | help
>>>>> On Wed, 16 Oct 2002 07:46:10 -0700,
>>>>> Luigi Rizzo <rizzo@icir.org> said:
> Actually from what i have read on previous postings on this thread,
> the only additional check that you might/will need is to make sure
> that m_tag_cookie corresponds to the GENERIC ABI.
(I re-read the thread) perhaps the example in my previous message
wasn't good (and it was at least incorrect). According to the
discussion on the thread, we'll probably keep m_tag_cookie being 0 and
use m_tag_id in (e.g.) ip6_output.c. So, we'll be happy if this
convention is kept (and will be kept) at least under netinet6.
It would be good to make more explicit comments on the intended usage,
not just a single comment for the m_tag_cookie member:
u_int32_t m_tag_cookie; /* Module/ABI */
> Also note that in your example the code should be conditional
> on __FreeBSD_version and not on __FreeBSD__
We (KAME) actually need __FreeBSD__, because we want to keep a single
code base for all *BSDs (again, I know this is our local issue). But,
whether or not we need __FreeBSD__ (in addition to __FreeBSD_version)
is a minor point. From our point view, we do want to avoid any ifdef
for separating different *BSDs.
Thanks,
JINMEI, Tatuya
Communication Platform Lab.
Corporate R&D Center, Toshiba Corp.
jinmei@isl.rdc.toshiba.co.jp
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-arch" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?y7vadle2r78.wl>