Date: Sat, 12 Sep 2015 15:45:16 -0700 From: hiren panchasara <hiren@strugglingcoder.info> To: Eric Joyner <erj@freebsd.org> Cc: Sean Bruno <sbruno@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r287465 - head/sys/dev/e1000 Message-ID: <20150912224516.GU64965@strugglingcoder.info> In-Reply-To: <CA%2Bb0zg84yTKgz_Nqv9FcrC2j38nLFrQn3X0GiwGKPnjcbPfOKw@mail.gmail.com> References: <201509041607.t84G7S6f029313@repo.freebsd.org> <20150904161813.GX68814@strugglingcoder.info> <CA%2Bb0zg84yTKgz_Nqv9FcrC2j38nLFrQn3X0GiwGKPnjcbPfOKw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--dRgc669pgRVB2OqT Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 09/12/15 at 07:23P, Eric Joyner wrote: > For the errata, the (lack of) details are in the specification updates for > HW like I210, I211, 82575 etc. It would be in the ones updated in August > 2015. Yes, I (we) know erratas are there in the h/w specs. Point is, which exact errata problem are you fixing here so I can go look up the spec for more detail. Errata number/name and exact spec should also be quoted for less ambiguity. (Think about someone having to debug this code 5 years down the road.) Cheers, Hiren >=20 > On Fri, Sep 4, 2015 at 9:18 AM hiren panchasara <hiren@strugglingcoder.in= fo> > wrote: >=20 > > + erj > > > > On 09/04/15 at 04:07P, Sean Bruno wrote: > > > Author: sbruno > > > Date: Fri Sep 4 16:07:27 2015 > > > New Revision: 287465 > > > URL: https://svnweb.freebsd.org/changeset/base/287465 > > > > > > Log: > > > igb(4): Update and fix HW errata > > > - HW errata workaround for IPv6 offload w/ extension headers > > It would be useful to know what is the actual problem here. > > > > > - Edited start of if_igb.c (Device IDs / #includes) to match ixgbe/= ixl > > I'd also prefer if such changes come via separate commits. :-) > > > > > > > > Differential Revision: https://reviews.freebsd.org/D3165 > > > Submitted by: erj > > > MFC after: 1 month > > > Sponsored by: Intel Corporation > > > > > > Modified: > > > head/sys/dev/e1000/if_igb.c > > > head/sys/dev/e1000/if_igb.h > > > > [skip] > > > > Cheers, > > Hiren > > --dRgc669pgRVB2OqT Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQF8BAABCgBmBQJV9Kr5XxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRBNEUyMEZBMUQ4Nzg4RjNGMTdFNjZGMDI4 QjkyNTBFMTU2M0VERkU1AAoJEIuSUOFWPt/lxScIAIuJYVZ0K0uguGYU6/OQvjCC tDWsiwxLql3OneTcy5tj5jUQA6SVq6RMPFnms2QKNduaa1Bbv+yt9XRCujYeTcOJ 6f3S59TCKi1Su4uITpTzDIkNPkLQ6ng0aAaJZhT4XE8GXkN9kDezOOVmblzDnCmf Cer+aGTXNq4W9f/NcbMI/JSrJkDJyYoH8pRhVPY1j/SG/PQl4dtMpo2VFXorILSR 0xH1VvQlvCKgAWKgYvzWVqVwURbNByZjmuluoj9PS4xb4s6b0Cj8gZvWIiGC/bn+ VQWiOQgc+cGLdCBLiFkvFqtkUBFHTAUeNt2VDCML/fAuIIpqt3xXU7/P4uqf5OY= =K5aS -----END PGP SIGNATURE----- --dRgc669pgRVB2OqT--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150912224516.GU64965>