Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 20 Aug 2001 22:53:06 -0700 (PDT)
From:      Matthew Jacob <mjacob@feral.com>
To:        Bill Paul <wpaul@FreeBSD.ORG>
Cc:        <hackers@FreeBSD.ORG>, <current@FreeBSD.ORG>
Subject:   Re: Where to put new bus_dmamap_load_mbuf() code
Message-ID:  <20010820225225.G39850-100000@wonky.feral.com>
In-Reply-To: <20010820223007.I39850-100000@wonky.feral.com>

next in thread | previous in thread | raw e-mail | index | archive | help

Correction.

This sample:
>
>         if (bus_dma_tag_create(pci->parent_dmat, PAGE_SIZE, lim,
>             BUS_SPACE_MAXADDR, BUS_SPACE_MAXADDR, NULL, NULL, len, 1,
>             BUS_SPACE_MAXSIZE_32BIT, 0, &pci->cntrol_dmat) != 0) {
>                 isp_prt(isp, ISP_LOGERR,
>                     "cannot create a dma tag for control spaces");
>                 free(isp->isp_xflist, M_DEVBUF);
>                 free(pci->dmaps, M_DEVBUF);
>                 return (1);
>         }
>

Should have been:

        if (bus_dma_tag_create(NULL, 1, 0, BUS_SPACE_MAXADDR_32BIT,
            BUS_SPACE_MAXADDR, NULL, NULL, lim + 1,
            255, lim, 0, &pcs->parent_dmat) != 0) {
                device_printf(dev, "could not create master dma tag\n");
                free(isp->isp_param, M_DEVBUF);
                free(pcs, M_DEVBUF);
                return (ENXIO);
        }



To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010820225225.G39850-100000>