Date: Sat, 7 Jul 2018 13:43:51 -0400 From: Mark Johnston <markj@freebsd.org> To: Andrew Turner <andrew@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org, sbruno@freebsd.org Subject: Re: svn commit: r334880 - head/sys/dev/vnic Message-ID: <20180707174351.GA95934@pesky> In-Reply-To: <201806091447.w59ElnpU026396@repo.freebsd.org> References: <201806091447.w59ElnpU026396@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Jun 09, 2018 at 02:47:49PM +0000, Andrew Turner wrote: > Author: andrew > Date: Sat Jun 9 14:47:49 2018 > New Revision: 334880 > URL: https://svnweb.freebsd.org/changeset/base/334880 > > Log: > In the ThunderX BGX network driver we were skipping the NULL terminator > when parsing the phy type, however this is included in the length returned > by OF_getprop. To fix this stop ignoring the terminator. > > PR: 228828 > Reported by: sbruno > Sponsored by: DARPA, AFRL This seems to break vnic on packet.net ThunderXs. In particular, VF creation fails. It seems the problem in my case is that there are multiple PHY devices in the device tree, e.g., xfi@0, xfi@1. With this change, bgx_fdt_phy_name_match() fails to match against any device containing a unit address in the node name.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180707174351.GA95934>