Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 5 Nov 2019 14:12:22 +0100
From:      Baptiste Daroussin <bapt@FreeBSD.org>
To:        Eugene Grosbein <eugen@FreeBSD.org>
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r515574 - head/security/cyrus-sasl2
Message-ID:  <20191105131059.bpgmjwj3ma5isi3i@ivaldir.net>
In-Reply-To: <201910250321.x9P3LHo9092172@repo.freebsd.org>
References:  <201910250321.x9P3LHo9092172@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--xsl5kxmfhrjd2riz
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Oct 25, 2019 at 03:21:17AM +0000, Eugene Grosbein wrote:
> Author: eugen
> Date: Fri Oct 25 03:21:16 2019
> New Revision: 515574
> URL: https://svnweb.freebsd.org/changeset/ports/515574
>=20
> Log:
>   security/cyrus-sasl2: unbreak building with stock OpenSSL for stable/11
>  =20
>   Sendmail bundled with FreeBSD has SASL support and the Handbook tells
>   how to rebuild the Sendmail with SASL enabled if you have installed
>   cyrus-sasl2 that links with OpenSSL's libcrypto.
>  =20
>   Sendmail uses old OpenSSL 1.0.2 API, so cyrus-sasl2 should be built
>   with stock libcrypto even if newer OpenSSL is installed for Ports.
>  =20
>   This change adds new option SSL to the port (enabled by default).
>   If disabled, cyrus-sasl2 is built witch stock libcrypto not depending
>   on ports version of OpenSSL.
>  =20
>   PORTREVISION not changed as default build is not affected.
>=20
> Modified:
>   head/security/cyrus-sasl2/Makefile
>   head/security/cyrus-sasl2/Makefile.common
>=20
> Modified: head/security/cyrus-sasl2/Makefile
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
> --- head/security/cyrus-sasl2/Makefile	Fri Oct 25 03:15:48 2019	(r515573)
> +++ head/security/cyrus-sasl2/Makefile	Fri Oct 25 03:21:16 2019	(r515574)
> @@ -11,13 +11,14 @@ CYRUS_CONFIGURE_ARGS=3D	--with-saslauthd=3D${SASLAUTH=
D_RUN
> =20
>  NO_OPTIONS_SORT=3D	yes
>  OPTIONS_DEFINE=3D		ALWAYSTRUE AUTHDAEMOND DOCS KEEP_DB_OPEN \
> -			OBSOLETE_CRAM_ATTR OBSOLETE_DIGEST_ATTR
> +			OBSOLETE_CRAM_ATTR OBSOLETE_DIGEST_ATTR SSL
>  OPTIONS_RADIO=3D		SASLDB
>  OPTIONS_RADIO_SASLDB=3D	BDB1 BDB GDBM LMDB
>  OPTIONS_GROUP=3D		PLUGIN
>  OPTIONS_GROUP_PLUGIN=3D	ANONYMOUS CRAM DIGEST LOGIN NTLM OTP PLAIN SCRAM
>  OPTIONS_DEFAULT=3D	ANONYMOUS AUTHDAEMOND BDB1 OBSOLETE_CRAM_ATTR CRAM \
> -			OBSOLETE_DIGEST_ATTR DIGEST LOGIN NTLM OTP PLAIN SCRAM
> +			OBSOLETE_DIGEST_ATTR DIGEST LOGIN NTLM OTP PLAIN SCRAM \
> +			SSL
>  OPTIONS_SUB=3D		yes
>  ALWAYSTRUE_DESC=3D	Alwaystrue password verifier (discouraged)
>  ALWAYSTRUE_CONFIGURE_ENABLE=3Dalwaystrue
> @@ -61,6 +62,8 @@ PLAIN_DESC=3D		PLAIN authentication
>  PLAIN_CONFIGURE_ENABLE=3D	plain
>  SCRAM_DESC=3D		SCRAM authentication
>  SCRAM_CONFIGURE_ENABLE=3D	scram
> +SSL_DESC=3D		Uncheck this to use system openssl libraries
> +SSL_USES=3D		ssl
> =20
I don't think this is the right approach.

1/ the option (double negative) is confusing.
2/ the default on for it makes it depends always on ports openssl, and mixi=
ng
port openssl and base openssl is always a mess for end users.

Best regards,
Bapt

--xsl5kxmfhrjd2riz
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEgOTj3suS2urGXVU3Y4mL3PG3PloFAl3BdN8ACgkQY4mL3PG3
Plrb7w//YwFGrTUN8j5WuwYXeoLp6G7D+VcjYBaf/DN6poM/Tq/llUkTKKjhWEeC
886FeVdn7xxCxhGFIsZvQfgXOGkgu86EaFMQFJbysPJj3KEZ99WCKDWTHFeYMMpM
KJDZJtesRlE4Js5QHcCapC0lPjLguj3SMZ4WeNJIquVlYT6k6cUJXZbwc+7qVcjW
wPb6RiRpgQXUn1kPw1RvIWcYYVDJfhgeJupNDD3ka6xupkearmJ5GzNktiCXbG6k
HSs/foTTs4DkQsMw1Z6qYCLie+r9Wa/R1ThJ76TOOoZF0kVrS2k29Ju7ji9h/bdS
Ol2uc6EOJUaaPRPdL102ZLY6iXi6VqUrOP7EIz0ySzxRScTMP/GuA4Xb3wCznx96
j1RJX15DiC2WC3kYNEx7fjJvvIYToLvRTA2kDgDfsCd5qBL7xbfFXyxbXKuBbF8M
HKyZRkN+Irq4L8K5peDsOOkFtYL+wsPh7xOD9E/IPNNQAbqwe/FFu0oHCXv5CU7c
AA8XmUdSFi6/T6Q9eLdhqJwh3ZDzJFyVjnSX4S+UM1dqQprYLWpmyWVgBYj7yAzo
+so/LhYRZEkT2t4n1ONA/T1K0tz11Y8QkL6Byp30ekT+zRHcPaFrf0WeTrZyjXfl
VW14zhzY4M6GBC/4qt7F3gGnSEUA3OD469/LC6BjN3nm4VBE6Bo=
=efsg
-----END PGP SIGNATURE-----

--xsl5kxmfhrjd2riz--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20191105131059.bpgmjwj3ma5isi3i>