Date: Thu, 17 Apr 2003 09:41:53 +0200 From: "Daan Vreeken [PA4DAN]" <Danovitsch@Vitsch.net> To: FreeBSD-hackers@FreeBSD.org Subject: kern/51074: pointer arithmatic error in ugen.c Message-ID: <200304170941.53069.Danovitsch@Vitsch.net>
next in thread | raw e-mail | index | archive | help
Hi, I have just submitted ker/51074: pointer arithmatic error in ugen.c ( http://www.FreeBSD.org/cgi/query-pr.cgi?pr=3Dkern%2F51074 ) with this description : I believe there is a pointer arithmatic error in line 965 of ugen.c . The entire piece of code reads : 961: /* throw away oldest input if the buffer is full */ 962: if(sce->fill < sce->cur && sce->cur <=3D sce->fill + count) { 963: sce->cur +=3D count; 964: if(sce->cur >=3D sce->limit) 965: sce->cur =3D sce->ibuf + (sce->limit - sce->cur); 966: DPRINTFN(5, ("ugen_isoc_rintr: throwing away %d bytes\n", 967: count)); 978: } count gets added to sce->cur . if the pointer equals/exceeds the end of the buffer, we move it to the beginnen of the buffer (plus the X bytes it was past the end). If sce->cur exceeds sce->limit, (sce->cur - sce->limit) would be a negati= ve value. (resulting in a sce->cur pointer sitting X bytes before the beginn= ing of the buffer) -- end -- Could someone please check if I'm correct and apply the patch? ps: thanks to some mailing-weirdness the pr is marked confidential, which= it=20 shouldn't have been.. :S thanks, Daan
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200304170941.53069.Danovitsch>