Date: Mon, 2 Jul 2018 10:56:10 -0400 From: "Jonathan T. Looney" <jtl@freebsd.org> To: steven.hartland@multiplay.co.uk Cc: Matt Macy <mmacy@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r335856 - in head/sys: netinet sys Message-ID: <CADrOrmse-LxVcV6oJZErprofTDBxBhPRKxnHm9OOoeGQ0yXHaQ@mail.gmail.com> In-Reply-To: <CAHEMsqYL9Eddpn=s%2BtEH3uD66gZww5eYa7M%2B13o_X6fMrC-2YQ@mail.gmail.com> References: <201807020519.w625JinG069138@repo.freebsd.org> <CAHEMsqYL9Eddpn=s%2BtEH3uD66gZww5eYa7M%2B13o_X6fMrC-2YQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Jul 2, 2018 at 10:44 AM Steven Hartland < steven.hartland@multiplay.co.uk> wrote: > > You have M_WAITOK and a null check in this change And, that's the same as the way it was before his commits. So, he did exactly what he said he was doing and reverted his commits. I don't think it is good practice to mix reverts with other changes. Since you've noticed this, I think you should feel free to make the change. Jonathan
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CADrOrmse-LxVcV6oJZErprofTDBxBhPRKxnHm9OOoeGQ0yXHaQ>