Date: Thu, 9 Oct 2003 18:30:11 -0700 (PDT) From: Shannon -jj Behrens <jj@nttmcl.com> To: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/57823: PATCH: obey portlint warnings Message-ID: <200310100130.h9A1UB93041361@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/57823; it has been noted by GNATS.
From: Shannon -jj Behrens <jj@nttmcl.com>
To: Adam Weinberger <adamw@FreeBSD.org>
Cc: FreeBSD-gnats-submit@FreeBSD.org, kbyanc@FreeBSD.org
Subject: Re: ports/57823: PATCH: obey portlint warnings
Date: Thu, 9 Oct 2003 18:21:51 -0700
On Thu, Oct 09, 2003 at 09:12:53PM -0400, Adam Weinberger wrote:
> >> (10.09.2003 @ 2055 PST): Shannon -jj Behrens said, in 1.5K: <<
> > diff ./Makefile /usr/ports/net/p5-Net-Radius/Makefile
> > 10d9
> > < PORTREVISION= 1
> > 18c18
> > < BUILD_DEPENDS= ${SITE_PERL}/${PERL_ARCH}/Digest/MD5.pm:${PORTSDIR}/security/p5-Digest-MD5
> > ---
> > > BUILD_DEPENDS= ${LOCALBASE}/lib/perl5/site_perl/${PERL_VER}/${PERL_ARCH}/Digest/MD5.pm:${PORTSDIR}/security/p5-Digest-MD5
> > 26c26
> > < ${FIND} ${WRKDIR} -type f | xargs perl -pi -e "s:\r::g"
> > ---
> > > find ${WRKDIR} -type f | xargs perl -pi -e "s:\r::g"
> >> end of "ports/57823: PATCH: obey portlint warnings" from Shannon -jj Behrens <<
>
> I think you ran diff with the arguments reversed. At least, I hope so.
You're right.
> Bumping PORTREVISION is unnecessary here, and the find line should be:
> ${FIND} ${WRKSRC} -type f | ${XARGS} ${PERL5} -pe -e "s:\r::g"
Excellent. It's obvious that you're paying attention, whereas I was
just blindly following portlint.
Thanks,
-jj
--
Research is the best place to be: you work your buns off, and if it
works you're a hero; if it doesn't, well--nobody else has done it yet
either, so you're still a valiant nerd.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200310100130.h9A1UB93041361>