Date: Fri, 26 Mar 2004 15:16:35 -0800 From: Kris Kennaway <kris@obsecurity.org> To: John Baldwin <jhb@freebsd.org> Cc: des@des.no Subject: Re: Is MTX_CONTESTED evil? Message-ID: <20040326231635.GA91340@xor.obsecurity.org> In-Reply-To: <200403261404.57741.jhb@FreeBSD.org> References: <200403260230.i2Q2UTNZ097932@green.homeunix.org> <xzpekrgf103.fsf@dwp.des.no> <20040326.113751.14204546.imp@bsdimp.com> <200403261404.57741.jhb@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--d6Gm4EdcadzBjdND Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Mar 26, 2004 at 02:04:57PM -0500, John Baldwin wrote: > On Friday 26 March 2004 01:37 pm, M. Warner Losh wrote: > > In message: <xzpekrgf103.fsf@dwp.des.no> > > > > des@des.no (Dag-Erling Sm?rgrav) writes: > > : "Brian F. Feldman" <green@FreeBSD.org> writes: > > : > Well, that certainly explains the blitz of crashes I had to fix > > : > recently! Since INVARIANTS and WITNESS are on by default, it would > > : > make sense to make ADAPTIVE_MUTEX default to catch more bugs. > > : > > : Making ADAPTIVE_MUTEXES default will not catch more bugs, it will just > > : piss off users. > > > > I think that if we don't fix the class of bugs that AM points out, > > we'll ruin our reputation as a quality system in the long run. Maybe > > they are so pervasive that we don't want to turn it on by default just > > yet, but there will come a time we turn it on, just like we turned on > > WITNESS and INVARIANTS to get better coverage on our testing. >=20 > Right, let's not just gratuitously break everyone right yet. It's actual= ly an=20 > option largely b/c I want us to be able to benchmark it once our locking = is=20 > farther along to see if it helps more than it hurts. FYI, I'm going to run with this on the bento cluster for a bit to dig out some of these bugs. Kris --d6Gm4EdcadzBjdND Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQFAZLnSWry0BWjoQKURArDUAJ46SbMSJ7n09fOkq4xLI2v+UumqbgCgr6VR z2aA1EdivOoO71pvYyqLF7c= =Vq/L -----END PGP SIGNATURE----- --d6Gm4EdcadzBjdND--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040326231635.GA91340>