Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 15 Dec 2007 01:17:14 GMT
From:      Qing Li <qingli@FreeBSD.org>
To:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   PERFORCE change 130920 for review
Message-ID:  <200712150117.lBF1HEWt083242@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=130920

Change 130920 by qingli@FreeBSD-newarp on 2007/12/15 01:17:05

	
	Forgot to initialize the callout in a newly created nd6 entry, causing the kernel to crash
	when callout_reset() is called on that entry for transition to the STALE state.

Affected files ...

.. //depot/projects/arp-v2/src/sys/netinet6/nd6.c#3 edit

Differences ...

==== //depot/projects/arp-v2/src/sys/netinet6/nd6.c#3 (text+ko) ====

@@ -804,8 +804,10 @@
 	if (create)
 		flags |= LLE_CREATE;      
 	ln = lla_lookup(ifp, flags, (struct sockaddr *)&sin6);
-	if ((ln != NULL) && (flags & LLE_CREATE))
+	if ((ln != NULL) && (flags & LLE_CREATE)) {
 		ln->ln_state = ND6_LLINFO_NOSTATE;
+		callout_init(&ln->ln_timer_ch, 0);
+	}
 	return (ln);
 }
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200712150117.lBF1HEWt083242>