Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 19 Apr 2015 17:34:44 +0000
From:      Alexey Dokuchaev <danfe@FreeBSD.org>
To:        Kurt Jaeger <pi@FreeBSD.org>
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r384307 - head/math/coinmp
Message-ID:  <20150419173444.GA77207@FreeBSD.org>
In-Reply-To: <201504191716.t3JHGwk2069000@svn.freebsd.org>
References:  <201504191716.t3JHGwk2069000@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Apr 19, 2015 at 05:16:58PM +0000, Kurt Jaeger wrote:
> New Revision: 384307
> URL: https://svnweb.freebsd.org/changeset/ports/384307
> 
> Log:
>   math/coinmp: change comma, target for check/test etc as suggested by danfe
>   
>   PR:		199502
>   Submitted by:	danfe

Wrong attribution; the PR was not submitted by me.

> [...]
>  check regression-test test: build
> -	@(cd ${WRKSRC}; ${SETENV} ${MAKE_ENV} ${MAKE} ${_MAKE_JOBS} \
> -	${MAKE_ARGS} test)
> +	${SETENV} ${MAKE_ENV} ${MAKE} ${_MAKE_JOBS} \
> +	${MAKE_ARGS} test -C ${WRKSRC}

Wrong indentation.  I'd appreciate if you'd waited for my final review,
given that I've suggested these improvements.

This is partially my fault since I didn't explain Carlos that PR was not
necessary for this at all clearly enough. :(

./danfe



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150419173444.GA77207>